chore: remove strict check on command arguments #23927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of #23907 I updated the dependency on `@types/yargs` to be in the `15` major version to reflect the version we use in the rest of the repo. Version `15` did not have the `strictOptions` yargs method so I attempted to enable `strict()` and disable `strictCommands` but it looks like that doesn't work. Removing strict altogether.
|
|
rix0rrr
approved these changes
Jan 31, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #23907 I updated the dependency on
@types/yargsto be in the15major version to reflect the version we use in the rest of the repo. Version15did not have thestrictOptionsyargs method so I attempted to enablestrict()and disablestrictCommandsbut it looks like that doesn't work. Removing strict altogether.Our only other option is to keep
@types/yargspinned at17.0.15since17.0.16is no longer compatible with our version of typescript.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license