Skip to content

Commit

Permalink
chore: remove strict check on command arguments (#23927)
Browse files Browse the repository at this point in the history
As part of #23907 I updated the dependency on `@types/yargs` to be in the `15` major version to reflect the version we use in the rest of the repo. Version `15` did not have the `strictOptions` yargs method so I attempted to enable `strict()` and disable `strictCommands` but it looks like that doesn't work. Removing strict altogether.

Our only other option is to keep `@types/yargs` pinned at `17.0.15` since `17.0.16` is no longer compatible with our version of typescript.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
corymhall authored Jan 31, 2023
1 parent ec73c39 commit 0757f67
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 6 deletions.
2 changes: 0 additions & 2 deletions packages/@aws-cdk-testing/cli-integ/bin/query-github.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ async function main() {
requiresArg: true,
}))
.demandCommand()
.strict()
.strictCommands(false)
.help()
.showHelpOnFail(false)
.argv;
Expand Down
2 changes: 0 additions & 2 deletions packages/@aws-cdk-testing/cli-integ/bin/run-suite.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ async function main() {
requiresArg: false,
})
.help()
.strict()
.strictCommands(false)
.showHelpOnFail(false)
.argv;

Expand Down
2 changes: 0 additions & 2 deletions packages/@aws-cdk-testing/cli-integ/bin/stage-distribution.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,6 @@ async function main() {
})
.demandCommand(1, 'You must supply a command')
.help()
.strict()
.strictCommands(false)
.showHelpOnFail(false)
.parse();
}
Expand Down

0 comments on commit 0757f67

Please sign in to comment.