Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(s3): notifications to existing buckets #15158

Merged
merged 178 commits into from
Jun 16, 2021
Merged

feat(s3): notifications to existing buckets #15158

merged 178 commits into from
Jun 16, 2021

Commits on Nov 29, 2020

  1. feat(aws-s3): Add notifications to existing buckets 

    Initial custom resource changes to support adding notifications to an existing S3 bucket

TODO: Move up the addNotification functions to BucketBase
    @michaelbrewer
    michaelbrewer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    b3cdf25 View commit details
    Browse the repository at this point in the history

  2. fix(aws-s3): Ensure we remove items removed in config 

    When removing elements from the existing configuration we should also check to remove the old configuration
    @michaelbrewer
    michaelbrewer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    bc61e13 View commit details
    Browse the repository at this point in the history

  3. feat(aws-s3): Move addEventNotification up to BucketBase 

    Move `addEventNotification` to BucketBase to support setting up bucket
notification on existing buckets
    @michaelbrewer
    michaelbrewer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    a27e096 View commit details
    Browse the repository at this point in the history

  4. fix(aws-s3): Remove unused import of Bucket

    @michaelbrewer
    michaelbrewer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    29fa6c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    905928e View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    66fb9f1 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    e902226 View commit details
    Browse the repository at this point in the history

  2. chore: Add temperary docs on existing bucket support

    @michaelbrewer
    michaelbrewer committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    81da2c1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    8704b7e View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. fix: Comment out uid=1000(michael) gid=1000(michael) groups=1000(mich… 

    …ael),4(adm),24(cdrom),27(sudo),30(dip),46(plugdev),120(lpadmin),131(lxd),132(sambashare),135(docker) and clarify code
    @michaelbrewer
    michaelbrewer committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    6b86f15 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    1d20d7d View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    3332daf View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    7f07f0a View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    a74c870 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2020

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    31ecb53 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2020

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    40194d6 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    9cbd839 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    d758759 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    2f21576 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    f380eec View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    27eeb15 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    a53c154 View commit details
    Browse the repository at this point in the history

  2. feat(handler): Add new python handler

    @michaelbrewer
    michaelbrewer committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    7063d8f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    49db8e2 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. docs(aws-kms): Add back tickets in documentation 

    Currently using semi quotes trancates the documentation
    @michaelbrewer
    michaelbrewer committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    ce664a9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    6e92c34 View commit details
    Browse the repository at this point in the history

  3. tests(s3-notifications): Add basic tests to the python handler

    @michaelbrewer
    michaelbrewer committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    2242baf View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. chore: Revert to using inline funciton

    @michaelbrewer
    michaelbrewer committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    931998c View commit details
    Browse the repository at this point in the history

  2. feat: Better handling of updates and create hash of arn

    @michaelbrewer
    michaelbrewer committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    8f5160c View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. docs(aws-kms): Add back tickets in documentation 

    Currently using semi quotes trancates the documentation
    @michaelbrewer
    michaelbrewer committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    92adf1d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    b02d7f5 View commit details
    Browse the repository at this point in the history

  3. fix: Currently handle buckets with no configurations

    @michaelbrewer
    michaelbrewer committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    987d0e8 View commit details
    Browse the repository at this point in the history

  4. test: Add some missing test cases

    @michaelbrewer
    michaelbrewer committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    c426e0e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    063a95e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    b393d56 View commit details
    Browse the repository at this point in the history

  2. tests: Complete test coverage

    @michaelbrewer
    michaelbrewer committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    7f30cae View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    69f0efb View commit details
    Browse the repository at this point in the history

  4. chore: Fix some linting errors

    @michaelbrewer
    michaelbrewer committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    c8edf9e View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    0dcedd1 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    4deece4 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    dba5cf6 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    40180ed View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    fbbd176 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    7cea114 View commit details
    Browse the repository at this point in the history

  2. fix(deps): Bump deps

    @michaelbrewer
    michaelbrewer committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    ef27749 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    c597267 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    00ae050 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    ccc890b View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    4e6d4b2 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    b7ad17b View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    3e46249 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e90decd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    ba4fede View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    d812ad4 View commit details
    Browse the repository at this point in the history

  2. fix: use python run and code review fixes

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    2b49ba3 View commit details
    Browse the repository at this point in the history

  3. refactor: make old_config not none

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    da844d2 View commit details
    Browse the repository at this point in the history

  4. fix(s3): set return type

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    3ccf3a4 View commit details
    Browse the repository at this point in the history

  5. test(s3): add missing semi

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    2fab734 View commit details
    Browse the repository at this point in the history

  6. chore: fix indent

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    efd42e8 View commit details
    Browse the repository at this point in the history

  7. chore: fix mypy errors

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    a0faddd View commit details
    Browse the repository at this point in the history

  8. refactor: do deepcopy on current config 

    Changes:
- fix: more mypy warnings
- refactor: do deepcopy on the current config
- test: add test verifying the error_message is sent to CFN
    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    c2302eb View commit details
    Browse the repository at this point in the history

  9. refactor: code cleanup and reveiw changes 

    Changes:
- Add mypy to project
- Make lint based updates
- Do merge in the filter
- Update tests to reflex these changes
    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    e210386 View commit details
    Browse the repository at this point in the history

  10. test(aws-s3): fix current tests

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    3868669 View commit details
    Browse the repository at this point in the history

  11. chore: bump ci

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    491747b View commit details
    Browse the repository at this point in the history

  12. tests: update tests

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    b15b0a2 View commit details
    Browse the repository at this point in the history

  13. test: update tests

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    179e607 View commit details
    Browse the repository at this point in the history

  14. test: update some of the integration tests

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    ba992ef View commit details
    Browse the repository at this point in the history

  15. tests: update more of the integration tests

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    b6642b3 View commit details
    Browse the repository at this point in the history

  16. test: inline python lambda

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    4642a90 View commit details
    Browse the repository at this point in the history

  17. test: update integration tests

    @michaelbrewer
    michaelbrewer committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    0ba5d84 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2021

  1. refactor: use pop

    @michaelbrewer
    michaelbrewer committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    003e5d6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    cb94c37 View commit details
    Browse the repository at this point in the history

  3. chore: update docs and include makefile

    @michaelbrewer
    michaelbrewer committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    291a8ad View commit details
    Browse the repository at this point in the history

  4. chore: configure black

    @michaelbrewer
    michaelbrewer committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    0e75507 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    b380e51 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    16635ea View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    8de9974 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    e9865db View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    0717da3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    6899aab View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. chore: rename makefile

    @michaelbrewer
    michaelbrewer committed May 3, 2021
    Configuration menu
    Copy the full SHA
    ea65ae4 View commit details
    Browse the repository at this point in the history

  2. chore: review changes 

    Co-authored-by: Eli Polonsky <Eli.polonsky@gmail.com>
    @michaelbrewer @iliapolo
    michaelbrewer and iliapolo committed May 3, 2021
    Configuration menu
    Copy the full SHA
    0614d14 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 3, 2021
    Configuration menu
    Copy the full SHA
    5e5f5fe View commit details
    Browse the repository at this point in the history

  4. chore: remove from local dev script

    @michaelbrewer
    michaelbrewer committed May 3, 2021
    Configuration menu
    Copy the full SHA
    4f1ed53 View commit details
    Browse the repository at this point in the history

  5. refactor: use makefile in Docker

    @michaelbrewer
    michaelbrewer committed May 3, 2021
    Configuration menu
    Copy the full SHA
    80c7461 View commit details
    Browse the repository at this point in the history

  6. refactor: more up addObjectCreatedNotification and addObjectRemovedNo… 

    …tification
    @michaelbrewer
    michaelbrewer committed May 3, 2021
    Configuration menu
    Copy the full SHA
    d592bb7 View commit details
    Browse the repository at this point in the history

  7. refactor: add from review changes

    @michaelbrewer
    michaelbrewer committed May 3, 2021
    Configuration menu
    Copy the full SHA
    f7573b6 View commit details
    Browse the repository at this point in the history

  8. chore: try sync up integ tests

    @michaelbrewer
    michaelbrewer committed May 3, 2021
    Configuration menu
    Copy the full SHA
    e8dedb1 View commit details
    Browse the repository at this point in the history

  9. chore: add missing change to integ

    @michaelbrewer
    michaelbrewer committed May 3, 2021
    Configuration menu
    Copy the full SHA
    cbad417 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 4, 2021
    Configuration menu
    Copy the full SHA
    1da09cc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 4, 2021
    Configuration menu
    Copy the full SHA
    e4d5743 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 4, 2021
    Configuration menu
    Copy the full SHA
    220ace2 View commit details
    Browse the repository at this point in the history

  4. fix(s3): support an upgrade path

    @michaelbrewer
    michaelbrewer committed May 4, 2021
    Configuration menu
    Copy the full SHA
    d36d01e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 6, 2021
    Configuration menu
    Copy the full SHA
    185066e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 6, 2021
    Configuration menu
    Copy the full SHA
    b64b354 View commit details
    Browse the repository at this point in the history

  3. tests: add more docs to tests

    @michaelbrewer
    michaelbrewer committed May 6, 2021
    Configuration menu
    Copy the full SHA
    41fa1fe View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 6, 2021
    Configuration menu
    Copy the full SHA
    cc09a68 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. chore: bump dependencies

    @michaelbrewer
    michaelbrewer committed May 7, 2021
    Configuration menu
    Copy the full SHA
    5b0c5f6 View commit details
    Browse the repository at this point in the history

  2. refactor: try to better find the modified configs

    @michaelbrewer
    michaelbrewer committed May 7, 2021
    Configuration menu
    Copy the full SHA
    affb92d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 7, 2021
    Configuration menu
    Copy the full SHA
    347ed55 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 8, 2021
    Configuration menu
    Copy the full SHA
    1dbf8d2 View commit details
    Browse the repository at this point in the history

  2. test: refactor the tests

    @michaelbrewer
    michaelbrewer committed May 8, 2021
    Configuration menu
    Copy the full SHA
    dc4f108 View commit details
    Browse the repository at this point in the history

  3. chore: more docs in tests

    @michaelbrewer
    michaelbrewer committed May 8, 2021
    Configuration menu
    Copy the full SHA
    5dbad6b View commit details
    Browse the repository at this point in the history

Commits on May 9, 2021

  1. chore: start add all of the possible scenarios

    @michaelbrewer
    michaelbrewer committed May 9, 2021
    Configuration menu
    Copy the full SHA
    d4ab01a View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 10, 2021
    Configuration menu
    Copy the full SHA
    53b2eb1 View commit details
    Browse the repository at this point in the history

  2. chore: prototpying replacement

    @michaelbrewer
    michaelbrewer committed May 10, 2021
    Configuration menu
    Copy the full SHA
    7b2f39d View commit details
    Browse the repository at this point in the history

  3. chore: remove the Id

    @michaelbrewer
    michaelbrewer committed May 10, 2021
    Configuration menu
    Copy the full SHA
    625dd25 View commit details
    Browse the repository at this point in the history

  4. chore: remove ids

    @michaelbrewer
    michaelbrewer committed May 10, 2021
    Configuration menu
    Copy the full SHA
    6ef2532 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. chore: remove ids

    @michaelbrewer
    michaelbrewer committed May 11, 2021
    Configuration menu
    Copy the full SHA
    0a7e01c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 11, 2021
    Configuration menu
    Copy the full SHA
    c1ef2a0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 11, 2021
    Configuration menu
    Copy the full SHA
    2301d65 View commit details
    Browse the repository at this point in the history

  4. refactor: to support with ids

    @michaelbrewer
    michaelbrewer committed May 11, 2021
    Configuration menu
    Copy the full SHA
    750dfeb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 11, 2021
    Configuration menu
    Copy the full SHA
    31d1ef3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 11, 2021
    Configuration menu
    Copy the full SHA
    4db892c View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 12, 2021
    Configuration menu
    Copy the full SHA
    98ff793 View commit details
    Browse the repository at this point in the history

  2. test(s3): add more test scenarios

    @michaelbrewer
    michaelbrewer committed May 12, 2021
    Configuration menu
    Copy the full SHA
    aaf424c View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 13, 2021
    Configuration menu
    Copy the full SHA
    f8fa084 View commit details
    Browse the repository at this point in the history

  2. tests: add pr recommended test cases

    @michaelbrewer
    michaelbrewer committed May 13, 2021
    Configuration menu
    Copy the full SHA
    022a957 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 15, 2021
    Configuration menu
    Copy the full SHA
    e32f984 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 17, 2021
    Configuration menu
    Copy the full SHA
    17fa17b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 17, 2021
    Configuration menu
    Copy the full SHA
    4b88f7a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 17, 2021
    Configuration menu
    Copy the full SHA
    e573010 View commit details
    Browse the repository at this point in the history

  4. fix(s3): handle rollback in progress

    @michaelbrewer
    michaelbrewer committed May 17, 2021
    Configuration menu
    Copy the full SHA
    22b827c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 17, 2021
    Configuration menu
    Copy the full SHA
    545c93c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 17, 2021
    Configuration menu
    Copy the full SHA
    444b950 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. test: fix tests run from docker

    @michaelbrewer
    michaelbrewer committed May 18, 2021
    Configuration menu
    Copy the full SHA
    f79fba7 View commit details
    Browse the repository at this point in the history

  2. fix(s3): handle adding duplicate config to an existing imported bucket

    @michaelbrewer
    michaelbrewer committed May 18, 2021
    Configuration menu
    Copy the full SHA
    5f05f74 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 19, 2021
    Configuration menu
    Copy the full SHA
    e88a4d0 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 20, 2021
    Configuration menu
    Copy the full SHA
    d719634 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 20, 2021
    Configuration menu
    Copy the full SHA
    1489ac2 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 22, 2021
    Configuration menu
    Copy the full SHA
    9d4ff4f View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 24, 2021
    Configuration menu
    Copy the full SHA
    a731eb2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 24, 2021
    Configuration menu
    Copy the full SHA
    04a825b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 24, 2021
    Configuration menu
    Copy the full SHA
    03589d5 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 25, 2021
    Configuration menu
    Copy the full SHA
    02b5504 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 26, 2021
    Configuration menu
    Copy the full SHA
    96fda90 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 26, 2021
    Configuration menu
    Copy the full SHA
    a15233f View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 27, 2021
    Configuration menu
    Copy the full SHA
    f762bca View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 28, 2021
    Configuration menu
    Copy the full SHA
    e0bb456 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 28, 2021
    Configuration menu
    Copy the full SHA
    8c5cd82 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 28, 2021
    Configuration menu
    Copy the full SHA
    35da0de View commit details
    Browse the repository at this point in the history

Commits on May 30, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed May 30, 2021
    Configuration menu
    Copy the full SHA
    2c1368a View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    3db1c06 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    15c4731 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    3312898 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    f8b5b8b View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    3d842c2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    b17345c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    31e5760 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    1028a7f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    4abebb4 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    d3b1668 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    849d71b View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    9e38971 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    71d29fd View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    f99f8e3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    b0ee74b View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. ID based implementation with different code paths for managed and unm… 

    …anaged buckets
    @iliapolo
    iliapolo authored and Your Name committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    92afb72 View commit details
    Browse the repository at this point in the history

  2. revert readme

    Your Name committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    54576a3 View commit details
    Browse the repository at this point in the history

  3. Merge pull request aws#243 from iliapolo/feat-add-notification-to-exi… 

    …sting-s3-bucket

chore: migrate to an ID based implementation and split managed and unmanaged bucket handling
    @michaelbrewer
    michaelbrewer committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    c5ff6b6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    c620e8a View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    dbf99e4 View commit details
    Browse the repository at this point in the history

  2. chore: black and mypy

    @michaelbrewer
    michaelbrewer committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    d3fb19c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2021

  1. chore: temp fix for build

    @michaelbrewer
    michaelbrewer committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    6ddca06 View commit details
    Browse the repository at this point in the history

  2. chore: reverts

    @michaelbrewer
    michaelbrewer committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    40fa31d View commit details
    Browse the repository at this point in the history

  3. added compat exclusion

    @iliapolo
    iliapolo committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    bddf35c View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Merge pull request aws#244 from iliapolo/feat-add-notification-to-exi… 

    …sting-s3-bucket
    @michaelbrewer
    michaelbrewer committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    0b2feb4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    fffba54 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    ded7c5c View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    02682d1 View commit details
    Browse the repository at this point in the history

  2. revert change to lambda event source

    @iliapolo
    iliapolo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    075fcb5 View commit details
    Browse the repository at this point in the history

  3. Merge pull request aws#245 from iliapolo/feat-add-notification-to-exi… 

    …sting-s3-bucket

chore: revert change to lambda event source
    @michaelbrewer
    michaelbrewer committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    453122c View commit details
    Browse the repository at this point in the history

  4. fix: revert breaking change exception

    @michaelbrewer
    michaelbrewer committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    3938c2b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    6fa65e6 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    5c5117e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    74e85f2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @michaelbrewer
    michaelbrewer committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    09a6204 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into feat-add-notification-to-existing-s3-bucket

    @mergify
    mergify[bot] committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    7b1cee2 View commit details
    Browse the repository at this point in the history