-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(s3): notifications to existing buckets #15158
feat(s3): notifications to existing buckets #15158
Conversation
Initial custom resource changes to support adding notifications to an existing S3 bucket TODO: Move up the addNotification functions to BucketBase
When removing elements from the existing configuration we should also check to remove the old configuration
Move `addEventNotification` to BucketBase to support setting up bucket notification on existing buckets
…ael),4(adm),24(cdrom),27(sudo),30(dip),46(plugdev),120(lpadmin),131(lxd),132(sambashare),135(docker) and clarify code
Currently using semi quotes trancates the documentation
Currently using semi quotes trancates the documentation
…sting-s3-bucket
…sting-s3-bucket chore: revert change to lambda event source
Sorry @iliapolo i had to move it to my personal github account |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
An update custom resource changes to support adding notifications to an existing S3 bucket Resolves aws#2004 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
An update custom resource changes to support adding notifications to an existing S3 bucket Resolves aws#2004 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
An update custom resource changes to support adding notifications to an existing S3 bucket
Resolves #2004
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license