chore: peerDependencies #1091
Merged
chore: peerDependencies #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds "peerDependencies" to all modules for all dependencies that include types that are used in the module's public API. Also, add "@aws-cdk/cdk" to "peerDependencies" for the typescript library cdk-init template. This will be enforced by jsii when aws/jsii#292 is introduced. Prerequisite for #272 Fixes #979
rix0rrr
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "peerDependencies" to all modules for all dependencies that
include types that are used in the module's public API.
Also, add "@aws-cdk/cdk" to "peerDependencies" for the typescript
library cdk-init template.
This will be enforced by jsii when aws/jsii#292 is introduced.
Prerequisite for #272
Fixes #979
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.