Package managers: deprecate @aws-cdk/aws-sam

[iamatypeofwalrus]

I ran into this with the latest version of aws-sam (0.13.0). According to #1137 this was meant to be fixed in #1091, however, that doesn't seem to be the case. After upgrading to the latest version of the cdk the @aws-cdk/aws-serverless works as expected.

Full error output:

[ts]
Argument of type 'this' is not assignable to parameter of type 'Construct'.
  Type 'QuizStack' is not assignable to type 'Construct'.
    Types of property 'parent' are incompatible.
      Type 'import("/Users/joe/code/quiz/node_modules/@aws-cdk/cdk/lib/core/construct").Construct | undefined' is not assignable to type 'import("/Users/joe/code/quiz/node_modules/@aws-cdk/aws-sam/node_modules/@aws-cdk/cdk/lib/core/construct").Construct | undefined'.
        Type 'import("/Users/joe/code/quiz/node_modules/@aws-cdk/cdk/lib/core/construct").Construct' is not assignable to type 'import("/Users/joe/code/quiz/node_modules/@aws-cdk/aws-sam/node_modules/@aws-cdk/cdk/lib/core/construct").Construct'.
          Types have separate declarations of a private property '_children'. [2345]

CDK Version: 0.19.0 (build 2625a05)
Package dot JSON:

{
  "name": "quiz",
  "version": "0.1.0",
  "bin": {
    "quiz2": "bin/quiz.js"
  },
  "scripts": {
    "build": "tsc",
    "watch": "tsc -w",
    "cdk": "cdk"
  },
  "devDependencies": {
    "@types/node": "^8.9.4",
    "typescript": "^3.1.2",
    "aws-cdk": "^0.19.0"
  },
  "dependencies": {
    "@aws-cdk/aws-sam": "^0.13.0",
    "@aws-cdk/cdk": "^0.19.0"
  }
}

[rix0rrr]

Yes, @aws-cdk/aws-sam is actually deprecated. You shouldn't be using it anymore. Let's figure out a way to make that clearer on NPM.

[iamatypeofwalrus]

👍 Can the docs also make it clear that its deprecated?

[eladb]

We have actually reverted the name to SAM and deprecated Serverless #2092 #2074