-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve WARM_IP_TARGET handling #461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
added
bug
enhancement
feature request
priority/P0
Highest priority. Someone needs to actively work on this.
labels
May 10, 2019
This was referenced May 10, 2019
vsiddharth
reviewed
May 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add more context to the description in the PR?
Provided initial set of comments.
(cherry picked from commit 803e5a8)
* Fixes issue where IPs are not allocated due ENIs being full
Adds the environment variables DISABLE_INTROSPECTION and DISABLE_METRICS to make it possible to turn off metrics and debugging.
tiffanyfay
approved these changes
May 15, 2019
This was referenced May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
enhancement
feature request
priority/P0
Highest priority. Someone needs to actively work on this.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #377, #294, #314, #391, #265 and others.
Description of changes:
Merge of all fixes that has gone into the 1.4 branch back into master. Add support for actually freeing unused IPs from an attached ENI. Requires the
ec2:UnassignPrivateIPs
permission.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.