Remove extra ENI when warm IP target is set #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove extra ENI when warm IP target is set * Modify max ENI check to allow for IP increase when warm IP target is set (Fixes issue where IPs are not allocated due ENIs being full)
nckturner
force-pushed
the
remove-extra-eni-for-warm-ip
branch
from
3143361 to
24ba739
Compare
mogren
reviewed
May 2, 2019
| otherWarmIPs += len(other.IPv4Addresses) - other.AssignedIPv4Addresses | ||
| } | ||
| } | ||
| log.Debugf("ENI %s otherWarmIPs: %d < warmIPTarget: %d: %v", eni.ID, otherWarmIPs, warmIPTarget, otherWarmIPs < warmIPTarget) |
There was a problem hiding this comment.
No need for this detailed logging here.
|
Superseded by #461 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.