Collect rp_filter from all network interface in aws-cni-support.sh #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #213 Currently `aws-cni-support.sh` outputs rp_filter from `eth0`. Although `eth0` is fixed value, some env have different name such as `ens5`. This patch changes the script to dump rp_filter from all interface on the host.
mogren
approved these changes
Mar 5, 2019
| @@ -66,7 +66,7 @@ ip route show table all >> $LOG_DIR/$ROUTE_OUTPUT | |||
|
|
|||
| # dump relevant sysctls | |||
| echo "================== sysctls ==================" > ${LOG_DIR}/sysctls.out | |||
| for f in /proc/sys/net/ipv4/conf/{all,default,eth0}/rp_filter; do | |||
| for f in /proc/sys/net/ipv4/conf/*/rp_filter; do | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently
aws-cni-support.shoutputs rp_filter frometh0. Althougheth0is fixed value, some env have different name such asens5,so the script fails on non-eth0 env.
This patch changes the script to collect rp_filter from all interface on
the host.
Issue
Fixes #213
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Additional Note
I considered to collect only specific interfaces, but I changed to
collect rp_filter from all interface with these reasons:
rp_filterfrom all ENI, the lines are less than 100.