Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scripts/aws-cni-support.sh to report sysctls on non-eth0 primary interface #213

Closed
ewbankkit opened this issue Oct 30, 2018 · 0 comments · Fixed by #338
Closed

Update scripts/aws-cni-support.sh to report sysctls on non-eth0 primary interface #213

ewbankkit opened this issue Oct 30, 2018 · 0 comments · Fixed by #338
Labels
enhancement good first issue

Comments

@ewbankkit
Copy link
Contributor

amazon-vpc-cni-k8s/scripts/aws-cni-support.sh

Lines 66 to 68 in 74ecf61

for f in /proc/sys/net/ipv4/conf/{all,default,eth0}/rp_filter; do
echo "$f = $(cat $f)" >> ${LOG_DIR}/sysctls.out
done

should be updated to report on any non-eth0 primary interface after merge of #196.

Maybe use

route | grep '^default' | grep -o '[^ ]*$'

to determine the primary interface name?
@ewbankkit ewbankkit mentioned this issue Oct 30, 2018
Closed
@nak3 nak3 mentioned this issue Mar 5, 2019
Merged
@mogren mogren added this to the v1.4 milestone Mar 5, 2019
@mogren mogren removed this from the v1.4 milestone Mar 13, 2019
rudoi pushed a commit to newrelic-forks/amazon-vpc-cni-k8s that referenced this issue Apr 1, 2019
@nak3
Dump rp_filter from all network interface
7c8825f 
Fixes aws#213

Currently `aws-cni-support.sh` outputs rp_filter from `eth0`. Although
`eth0` is fixed value, some env have different name such as `ens5`.

This patch changes the script to dump rp_filter from all interface on
the host.
mogren pushed a commit to mogren/amazon-vpc-cni-k8s that referenced this issue Apr 25, 2019
@nak3
Dump rp_filter from all network interface
a910220 
Fixes aws#213

Currently `aws-cni-support.sh` outputs rp_filter from `eth0`. Although
`eth0` is fixed value, some env have different name such as `ens5`.

This patch changes the script to dump rp_filter from all interface on
the host.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Collect rp_filter from all network interface in aws-cni-support.sh
2 participants
@mogren @ewbankkit