add AWS_EC2_ENDPOINT variable for custom endpoint (#2317) #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
reviewed
Mar 21, 2023
There was a problem hiding this comment.
Thanks for making this change @jihunseol ! Can you also add an entry in README.md and a small unit-test similar to the original PR? For the README, you can set the version introduced as "v1.13.0+".
Also, can you confirm that you built your own image and tested on k8s 1.25?
|
Sure, I will add an entry in README.md and unit-test also. And I can confirm that latest master image with PR is tested and worked on k8s 1.25. |
jdn5126
suggested changes
Mar 22, 2023
jdn5126
previously approved these changes
Mar 27, 2023
|
@jihunseol thanks for the help here! I approved, rebased, and kicked off testing. I'll merge after the tests pass |
jdn5126
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
#2317
What does this PR do / Why do we need it:
This PR enables the usage of a custom endpoint for AWS API requests by reading the 'AWS_EC2_ENDPOINT' environment variable. This feature is particularly useful for testing environments that are compatible with the AWS API.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Manually verified that kubernetes cluster version 1.25.6 on testing environment.
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.