-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom AWS endpoint configuration. #2317
Comments
@jihunseol yeah, this was brought up before in #2101 . We have been trying to push for no more non-functional environment variables, but an environment variable may be the only reasonable approach here. If you would like to revive this old PR and follow the approach from ebs-csi-driver (https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/pkg/cloud/cloud.go#L252), I am ok with that. Just need to do some testing |
@jdn5126 I noticed that the previously closed pull request has already addressed the issue. It would be helpful to reopen the old PR instead of opening a new one to avoid duplicate work. Thanks for considering the issue. |
That's fine with me too, but I don't think the individual who opened that initial PR is working on this or following it, so it probably needs someone new to drive it |
Thank you for letting me know. If there is no issue, I would be happy to take one the responsibility of driving this pull request forward. |
Awesome, thank you so much for the help! |
I have submitted pull request #2326 to address the issue. As per the approach used in ebs-csi-driver, I have skipped unit testing for this code. |
* add AWS_EC2_ENDPOINT variable for custom endpoint (#2317)
|
What would you like to be added:
Is there any plan to support custom AWS endpoint configuration for AWS VPC CNI plugin?
To use AWS VPC CNI plugin for custom AWS endpoint environment(e.g. testing environment), it would be great to support custom AWS endpoint configuration like below.
Why is this needed:
In order to use AWS VPC CNI plugin for testing environment(AWS API compatible), it is necessary to support custom AWS endpoint configuration.
The text was updated successfully, but these errors were encountered: