Add resources to init container #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
force-pushed
the
init_resources
branch
from
1f850e9 to
caf5a7c
Compare
achevuru
previously approved these changes
Jan 12, 2023
jdn5126
force-pushed
the
init_resources
branch
from
caf5a7c to
889ffd8
Compare
jdn5126
force-pushed
the
init_resources
branch
from
889ffd8 to
01e98c0
Compare
jdn5126
force-pushed
the
init_resources
branch
from
01e98c0 to
3d3da25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement
Which issue does this PR fix:
#2191
aws/eks-charts#470
aws/eks-charts#738
What does this PR do / Why do we need it:
This PR sets the resources for the init container to the same value specified for the main container. The init container needed resources to be specified for the issues linked above, and since the init container is a short-lived container, the actual values are less important than simple configuration.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Verified that resources are applied to init container and that integration tests run without issue.
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No, this will not break upgrades or downgrades. A running cluster has been tested.
Does this change require updates to the CNI daemonset config files to work?:
Yes
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.