Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource limit on init container in eks addon #2191

Closed
pdeva opened this issue Jan 2, 2023 · 3 comments
Closed

resource limit on init container in eks addon #2191

pdeva opened this issue Jan 2, 2023 · 3 comments

Comments

@pdeva
Copy link

pdeva commented Jan 2, 2023

Using latest version of AWS VPC CNI Addon: v1.12.0-eksbuild.1
The default configuration has no resource limit specified for the init container.

The newly added Addon configuration setting only allows setting resources for the primary container but not the init container.

What would you like to be added:
The addon configuration should allow setting resource limits for the init container too.

Why is this needed:
Recommended practice to ensure k8s scheduler can sucessfully schedule pods. Also helps user to know/control the resource usage of this container.

@achevuru
Copy link
Contributor

achevuru commented Jan 2, 2023

@pdeva Yes and that is because we currently don't have any resource limits/requests settings in the init container spec in our default manifest. We don't currently specify any limits/reqs because this is not a long running container and CNI will not even move to running state without init container successfully completing it's work (and exiting). Node will fail to move to Ready state without VPC CNI pod up and running and so we didn't see a need to cap any resources for the init container.

@jdn5126
Copy link
Contributor

jdn5126 commented Jan 24, 2023

Closing as fixed by #2205. This will ship in v1.13.0

@jdn5126 jdn5126 closed this as completed Jan 24, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants