Added config map for env vars

[nithu0115]

Issue #, if available: N/A

Description of changes:
Moved all env vars to a configmap to persist these variable during CNI update

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[jaypipes]

👍 nice cleanup, @nithu0115, thanks!

[anguslees]

(lgtm fwiw, with the usual mild ConfigMap concern about how we tell users they should rollout a change to the configmap - since it won't "just happen" anymore. I think it's a net win to be clear, and a conservative admin most likely isn't blindly consuming our manifests without modification anyway.)

[dschunack]

Hi,

what's the current state here? In the last month it was pushed only release to release.

[TBBle]

As well as rebasing, this PR probably needs to have the Helm chart support added, which has appeared in this repo via #1271 since this PR was originally created.

[jayanthvn]

Hi @TBBle.

Yes once we add the config map support we need to fix the helm for config map.

@dschunack,
With config maps along + DaemonSet there is no vanilla k8s support for rolling upgrade when config map is modified. We are working on this and should have some updates in the following weeks.

[julianxhokaxhiu]

What's the current milestone for this PR? This gets even more urgent now that for eg. in order to allow nodes having more Pods we need to enable an environment variable ( see https://aws.amazon.com/blogs/containers/amazon-vpc-cni-increases-pods-per-node-limits/ ).

Having a ConfigMap would help here instead of running a custom kubectl set env command on each installation ( and which also can't be automated via Terraform... ).

Thanks!

[dschunack]

Hi @jayanthvn ,

What's the current state of this PR?

[mlschindler]

Any updates on this issue? It is rather cumbersome for us to use hacky config management with Terraform (kubectl provider, local null resources, etc) and not to mention needing to bounce nodes when this style of management fails (as it does a little too frequently).

[dschunack]

Any Update?

[github-actions]

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

[dschunack]

Still waiting on this

[jdn5126]

Using ConfigMap to source environment variables for CNI is being tracked as a v2.x task, as rolling update with ConfigMap + daemonset pod needs more investigation. In the meantime, kubectl set env is the recommended mechanism.

This PR will not merge as is, but will be left open for those tracking. #2102 is the associated the issue, so please track this going forward.

[github-actions]

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

[github-actions]

Pull request closed due to inactivity.