Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EKS] [request]: Move VPC CNI configuration settings to ConfigMap #865

Open
mikestef9 opened this issue Apr 28, 2020 · 4 comments
Open

[EKS] [request]: Move VPC CNI configuration settings to ConfigMap #865

mikestef9 opened this issue Apr 28, 2020 · 4 comments
Labels
EKS Amazon Elastic Kubernetes Service Proposed Community submitted issue

Comments

@mikestef9
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request
Add an option for the VPC CNI to pull configuration settings from a Kubernetes ConfigMap

Which service(s) is this request for?
EKS

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Today, all VPC CNI configuration settings must be specified as environment variables on the aws-node daemonset. This can make upgrading difficult, as a new version of the VPC CNI may have a different manifest, but has all default settings. We should be able to follow upgrade instructions without worrying about configuration settings.

Are you currently working around this issue?
Download new manifest file, manually edit environment variables, then apply to cluster.

@sftim
Copy link

sftim commented Aug 19, 2021

Hi. Are there any details about what the format of the ConfigMap might look like?

@TBBle
Copy link

TBBle commented Aug 19, 2021

aws/amazon-vpc-cni-k8s#1088 was an approved but not merged (not clear why) PR, which introduces a ConfigMap like this: https://github.com/aws/amazon-vpc-cni-k8s/pull/1088/files#diff-94446c74858d682e37df1247778b6245243289fb4db689921a0bfa298cd47bc5

There wasn't any objection raised to the format that I can see, so that seems like the most-likely structure to go ahead, but the PR needs to be updated to the current state of that project first.

@sftim
Copy link

sftim commented Aug 19, 2021

aws/amazon-vpc-cni-k8s#1088 doesn't define a ConfigMap for the CNI plugin to load; rather, it uses Kubernetes APIs to separate the storage of those environment variables from the Pod template in the sample DaemonSet. Maybe that's good enough for what @mikestef9 had in mind?

@TBBle
Copy link

TBBle commented Aug 19, 2021

Yeah, @mikestef9 agreed that that PR resolved his need: aws/amazon-vpc-cni-k8s#1088 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EKS Amazon Elastic Kubernetes Service Proposed Community submitted issue
Projects
None yet
Development

No branches or pull requests

3 participants