added warning if delete on termination is set to false for the primar… #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the review @mogren. I have made the changes :) |
mogren
pushed a commit
that referenced
this pull request
Jun 15, 2020
* Add support for c5a and c5ad (cherry picked from commit fe8d9b6) * added warning if delete on termination is set to false for the primar… (#1024) * Added a warning message if delete on termination is set to false for the primary ENI (cherry picked from commit 6d52e1b) Co-authored-by: jayanthvn <1111446+jayanthvn@users.noreply.github.com>
bnapolitan
added a commit
to bnapolitan/amazon-vpc-cni-k8s
that referenced
this pull request
Jul 1, 2020
commit d938e5e Author: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Date: Wed Jul 1 01:19:14 2020 +0000 Json o/p for logs from entrypoint.sh commit 2d20308 Author: Nathan Prabhu <natprabh@amazon.com> Date: Mon Jun 29 18:06:22 2020 -0500 bugfix: make metrics-helper docker logging statement multi-arch compatible commit bf9ded3 Author: Claes Mogren <claes.mogren@gmail.com> Date: Sat Jun 27 14:51:35 2020 -0700 Use install command instead of cp commit e3b7dbb Author: Gyuho Lee <leegyuho@amazon.com> Date: Mon Jun 29 09:40:02 2020 -0700 scripts/lib: bump up tester to v1.4.0 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> commit c369480 Author: Claes Mogren <claes.mogren@gmail.com> Date: Sun Jun 28 12:19:27 2020 -0700 Some refresh cleanups commit 8c266e9 Author: Claes Mogren <claes.mogren@gmail.com> Date: Sun Jun 28 18:37:46 2020 -0700 Run staticcheck and clean up commit 8dfc5b1 Author: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Date: Sun Jun 28 17:39:20 2020 -0700 Fix integration test script for code pipeline (aws#1062) Co-authored-by: Claes Mogren <mogren@amazon.com> commit 52306be Author: Murcherla <nithu0115@gmail.com> Date: Wed Jun 24 23:37:24 2020 -0500 minor nits, fast follow up to PR 903 commit 4ddd248 Author: Claes Mogren <mogren@amazon.com> Date: Sun Jun 14 23:20:22 2020 -0700 Add bandwidth plugin commit 6d35fda Author: Robert Sheehy <gameboy1092@gmail.com> Date: Fri May 22 21:11:12 2020 -0500 Chain interface to other CNI plugins commit 30f98bd Author: Penugonda <saiteja313@gmail.com> Date: Thu Jun 25 15:14:00 2020 -0400 removed custom networking default vars, introspection var commit aa8b818 Author: Penugonda <saiteja313@gmail.com> Date: Wed Jun 24 19:11:38 2020 -0400 updated manifest configs with default env vars commit a073d66 Author: Nithish Murcherla <nithu0115@gmail.com> Date: Wed Jun 24 16:51:38 2020 -0500 refresh subnet/CIDR information every 30 seconds and update ip rules to map pods (aws#903) Co-authored-by: Claes Mogren <mogren@amazon.com> commit a0da387 Author: Claes Mogren <mogren@amazon.com> Date: Wed Jun 24 12:30:45 2020 -0700 Default to random-fully (aws#1048) commit 9fea153 Author: Claes Mogren <mogren@amazon.com> Date: Sun Jun 14 22:37:10 2020 -0700 Update probe settings * Reduce readiness probe startup delay * Increase liveness polling period * Reduce shutdown grace period to 10 seconds commit ad7df34 Author: Jay Pipes <jaypipes@gmail.com> Date: Wed Jun 24 02:06:23 2020 -0400 Remove timeout for ipamd startup (aws#874) * add configurable timeout for ipamd startup Adds a configurable timeout to the aws-k8s-agent (ipamd) startup in the entrypoint.sh script. Increases the default timeout from ~30 seconds to 60 seconds. Users can set the IPAMD_TIMEOUT_SECONDS environment variable to change the timeout. Related: aws#625, aws#865 aws#872 * This is a local gRPC call, so just try every 1 second indefinitely Since we have a liveness probe restarting the probe, we can rely on that to kill the pod. Co-authored-by: Claes Mogren <mogren@amazon.com> commit 1af40d2 Author: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Date: Fri Jun 19 10:14:44 2020 -0700 Changelog and config file changes for v1.6.3 commit 14d5135 Author: Ari Becker <ari-becker@users.noreply.github.com> Date: Wed Jun 17 09:39:21 2020 +0300 Generated the different configurations commit 00395cb Author: Ari Becker <ari-becker@users.noreply.github.com> Date: Tue Jun 16 14:33:55 2020 +0300 Fix discovery RBAC issues in Kubernetes 1.17 commit 7e224af Author: Gyuho Lee <leegyuho@amazon.com> Date: Mon Jun 15 16:04:44 2020 -0700 scripts/lib/aws: bump up tester to v1.3.9 Includes improvements to log fetcher + MNG deletion when metrics server is installed. Signed-off-by: Gyuho Lee <leegyuho@amazon.com> commit 36286ba Author: Claes Mogren <mogren@amazon.com> Date: Mon Jun 15 07:56:59 2020 -0700 Remove Printf and format test (aws#1027) commit af54066 Author: Gyuho Lee <leegyuho@amazon.com> Date: Sat Jun 13 01:31:08 2020 -0700 scripts/lib/aws: tester v1.3.6, enable color outputs (aws#1025) Includes various bug fixes + color output if $TERM is supported. Fallback to plain text output automatic. ref. https://github.com/aws/aws-k8s-tester/blob/master/CHANGELOG/CHANGELOG-1.3.md#v136-2020-06-12 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> commit 6d52e1b Author: jayanthvn <1111446+jayanthvn@users.noreply.github.com> Date: Fri Jun 12 16:26:33 2020 -0700 added warning if delete on termination is set to false for the primar… (aws#1024) * Added a warning message if delete on termination is set to false for the primary ENI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y eni
Issue #, if available: #1023
Description of changes:
Added a warning message if primary eni has delete on termination set to false.
For UT, I set the delete on termination to false and below ipamd log shows the warning -
{"level":"debug","ts":"2020-06-12T19:50:46.104Z","caller":"awsutils/awsutils.go:442","msg":"Found ENI: eni-07f2cc3f10e738161, MAC 0a:fb:8c:29:a9:58, device 2"}
{"level":"debug","ts":"2020-06-12T19:50:46.104Z","caller":"awsutils/awsutils.go:462","msg":"Found CIDR 192.168.64.0/19 for ENI 0a:fb:8c:29:a9:58"}
{"level":"debug","ts":"2020-06-12T19:50:46.105Z","caller":"awsutils/awsutils.go:462","msg":"Found IP addresses [192.168.71.210 192.168.82.25 192.168.86.90 192.168.94.77 192.168.91.157 192.168.75.142 192.168.64.191 192.168.71.80 192.168.95.18 192.168.72.36] on ENI 0a:fb:8c:29:a9:58"}
{"level":"warn","ts":"2020-06-12T19:50:46.202Z","caller":"ipamd/ipamd.go:328","msg":"Primary ENI will not get deleted when node terminates because 'delete_on_termination' is set to false"}
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.