incorporated the review comments and made a null sanity check

aws · Jun 12, 2020 · 119f25a · 119f25a
1 parent 8ae5cd1
commit 119f25a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/awsutils/awsutils.go b/pkg/awsutils/awsutils.go
@@ -1004,6 +1004,9 @@ func (cache *EC2InstanceMetadataCache) DescribeAllENIs() ([]ENIMetadata, map[str
 	// Collect ENI response into ENI metadata and tags.
 	tagMap := make(map[string]TagMap, len(ec2Response.NetworkInterfaces))
 	for _, ec2res := range ec2Response.NetworkInterfaces {
+		if ec2res.Attachment != nil && aws.Int64Value(ec2res.Attachment.DeviceIndex) == 0 && !aws.BoolValue(ec2res.Attachment.DeleteOnTermination) {
+			log.Warn("Primary ENI will not get deleted when node terminates because 'delete_on_termination' is set to false")
+		}
 		eniID := aws.StringValue(ec2res.NetworkInterfaceId)
 		eniMetadata := eniMap[eniID]
 		// Check IPv4 addresses
@@ -1019,9 +1022,6 @@ func (cache *EC2InstanceMetadataCache) DescribeAllENIs() ([]ENIMetadata, map[str
 		if len(tags) > 0 {
 			tagMap[eniMetadata.ENIID] = tags
 		}
-		if aws.Int64Value(ec2res.Attachment.DeviceIndex) == 0 && !aws.BoolValue(ec2res.Attachment.DeleteOnTermination) {
-			log.Warn("Primary ENI will not get deleted when node terminates because 'delete_on_termination' is set to false")
-		}
 	}
 	return verifiedENIs, tagMap, nil
 }