This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
fix: add deploy before destroy in all english docs #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh gosh, how embarrassing i realized I re-formatted all the files. Feel free to just close this if thats not good and i'll redo it. EDIT - fixed this, should be fine now. |
mobob
force-pushed
the
mobob/docs_deploybeforedestroy
branch
from
77225f4
to
c220fc3
Compare
|
This should be a-ok now, let me know if there are any issues or things you'd like changed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 1131
Running through the TS sample, i followed to the letter and then didn't get my DB deleted after destroy. The docs could be improved with the suggestion of deploying prior to destroy... checking the other languages, Java had this but none of the other languages. So i duplicated it's exact text for all other languages.
NOTE: Japanese still does not have this.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 License.