Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Not all languages have a "deploy" before "destroy" step #1131

Closed
Tracked by #1170
mobob opened this issue Aug 9, 2023 · 4 comments
Closed
Tracked by #1170

Not all languages have a "deploy" before "destroy" step #1131

mobob opened this issue Aug 9, 2023 · 4 comments
Assignees
Labels
bug This issue is a bug. p2

Comments

@mobob
Copy link
Contributor

mobob commented Aug 9, 2023

Describe the bug

Before the cdk destroy step, if you don't deploy your dynamo db doesn't get cleaned up.

Expected Behavior

The docs should at least suggest deploying before destroying.

Current Behavior

Deploy is not suggested.

Reproduction Steps

Read the docs.

Possible Solution

Update the docs to suggest deploy before destroy.

Additional Information/Context

No response

CDK CLI Version

No response

Section

No response

Browser

No response

Language

No response

@mobob mobob added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 9, 2023
@mobob
Copy link
Contributor Author

mobob commented Aug 17, 2023

FYI i did submit a PR for this: #1132

@indrora indrora mentioned this issue Sep 13, 2023
23 tasks
@ashishdhingra
Copy link
Contributor

FYI i did submit a PR for this: #1132

@mobob Thanks for the PR. We will review and merge it.

@ashishdhingra ashishdhingra added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 17, 2024
@ashishdhingra ashishdhingra self-assigned this Apr 17, 2024
@ashishdhingra
Copy link
Contributor

PR merged.

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. p2
Projects
None yet
Development

No branches or pull requests

2 participants