Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove push from github action and update CodeQL version to v2 since … #139

Merged
merged 1 commit into from
Sep 7, 2022
Merged

remove push from github action and update CodeQL version to v2 since … #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Run build/tests/lint on pull requests

on:
pull_request:
push:

# By default the karma test runners use the karma 'Chrome' runner
# This is great when running locally because the browser pops up and you get to see what it does
Expand All @@ -20,7 +19,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
uses: github/codeql-action/init@v2
- uses: actions/setup-node@v3
with:
node-version: '16.x'
Expand All @@ -29,4 +28,4 @@ jobs:
- run: npm run build-test
- name: Perform CodeQL Analysis
if: matrix.os == 'ubuntu-latest' # we only need to run this check on one platform
uses: github/codeql-action/analyze@v1
uses: github/codeql-action/analyze@v2