Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove push from github action and update CodeQL version to v2 since … #139

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

eherozhao
Copy link
Contributor

Description

The dependbot failed to merge for a Github Action push so we removed push from the action. Meanwhile, the CodeQL v1 will deprecate this December so we updated it to v2 in this PR.

Related Issue

Reviewer Testing Instructions

For me, I restored the dependbot branch and create a pull request for that branch to my dev removePush branch and the Action works well without error.

Submission Checklist

I confirm that I have...

  • removed hard-coded Cognito IDs
  • manually smoke-tested the BabylonJS integration tests
  • manually smoke-tested the BabylonJS demos
  • manually smoke-tested the Three.js integration tests
  • manually smoke-tested the Three.js demo

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eherozhao eherozhao merged commit dec55fb into mainline2.0 Sep 7, 2022
@eherozhao eherozhao deleted the removePush branch September 7, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants