Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update AMP collector configuration #868

Merged
merged 1 commit into from
Nov 7, 2023
Merged

update AMP collector configuration #868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/addons/amp/collector-config-amp.ytpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,14 @@ metadata:
namespace: "{{namespace}}"
spec:
mode: "{{deploymentMode}}"
image: public.ecr.aws/aws-observability/aws-otel-collector:v0.21.0
image: public.ecr.aws/aws-observability/aws-otel-collector:v0.33.1
resources:
limits:
cpu: "1"
memory: "2Gi"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not this be configurable? Do you foresee cases that this particular constraint won't work in production for larger volumes?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be made configurable but this configuration is for collector so we dont run in to constraint in production also this is the config received from service team.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not questioning the need for the settings, I actually like them. We can apply for now, but these are hard coded and there will be no way for customers to override them if needed. Let's wait for the customer signals ;)

requests:
cpu: "1"
memory: "2Gi"
serviceAccount: adot-collector
config: |
receivers:
Expand Down
Loading