Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update AMP collector configuration #868

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

ratnopamc
Copy link
Contributor

Issue #, if available:
#863
Description of changes:
Updated AMP collector configuration to use latest otel collector image and also set request and limits.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @shapirov103 Please check and run e2e.

@elamaran11
Copy link
Collaborator

@shapirov103 Could we run e2e here?

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my question.

resources:
limits:
cpu: "1"
memory: "2Gi"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not this be configurable? Do you foresee cases that this particular constraint won't work in production for larger volumes?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be made configurable but this configuration is for collector so we dont run in to constraint in production also this is the config received from service team.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not questioning the need for the settings, I actually like them. We can apply for now, but these are hard coded and there will be no way for customers to override them if needed. Let's wait for the customer signals ;)

@shapirov103
Copy link
Collaborator

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

@shapirov103 shapirov103 merged commit 8daa266 into aws-quickstart:main Nov 7, 2023
8 checks passed
@Howlla
Copy link
Contributor

Howlla commented Nov 8, 2023

Ran e2e for aws observability accelerator Graviton and OSS Patterns with latest otel collector. works as intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants