-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update AMP collector configuration #868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @shapirov103 Please check and run e2e.
@shapirov103 Could we run e2e here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my question.
resources: | ||
limits: | ||
cpu: "1" | ||
memory: "2Gi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not this be configurable? Do you foresee cases that this particular constraint won't work in production for larger volumes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be made configurable but this configuration is for collector so we dont run in to constraint in production also this is the config received from service team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not questioning the need for the settings, I actually like them. We can apply for now, but these are hard coded and there will be no way for customers to override them if needed. Let's wait for the customer signals ;)
/do-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end to end tests passed
Ran e2e for aws observability accelerator Graviton and OSS Patterns with latest otel collector. works as intended |
Issue #, if available:
#863
Description of changes:
Updated AMP collector configuration to use latest otel collector image and also set request and limits.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.