chore: updates for compatibility with deadline-cloud-test-fixtures #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jericht
force-pushed
the
jericht/test_fixtures_update
branch
from
915e476
to
7511058
Compare
Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
jericht
force-pushed
the
jericht/test_fixtures_update
branch
from
7511058
to
fb049ec
Compare
jericht
changed the title
amarsjac
approved these changes
Apr 23, 2024
|
moorec-aws
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We have some fixtures defined in
test/conftest.pywhich conflict with fixtures indeadline-cloud-test-fixturesthat we use in our integration tests, preventing the tests from running.What was the solution? (How)
Move the fixtures in
test/conftest.pytotest/unit/conftest.pysince they are only needed for unit testsWhat is the impact of this change?
Our integration tests can run
How was this change tested?
hatch build && hatch run testWas this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.