fix!: set AWS_ENDPOINT_URL_DEADLINE after installing service model #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jericht
force-pushed
the
jericht/endpoint_url
branch
from
b4e40b6
to
68ba4d0
Compare
jericht
changed the title
jericht
force-pushed
the
jericht/endpoint_url
branch
2 times, most recently
from
8c72551
to
a0c8f2f
Compare
moorec-aws
approved these changes
Apr 22, 2024
jusiskin
requested changes
Apr 22, 2024
BREAKING CHANGE: The ServiceModel class no longer has the "install_command" or "file_path" attributes. Also, the WORKER_REGION configuration option has been deprecated. Use REGION instead. Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
jericht
force-pushed
the
jericht/endpoint_url
branch
from
a0c8f2f
to
c7377a7
Compare
|
jusiskin
approved these changes
Jun 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Main issue:
AWS_ENDPOINT_URL_DEADLINEto tell boto that we want requests to Deadline Cloud to go to a different endpoint.Small issues:
KEEP_WORKER_AFTER_FAILUREconfiguration was not working, workers are still shutting down after failing to startWORKER_REGIONconfiguration is unnecessarily specific to the worker. The region can be applied to all components created by the test fixtures.What was the solution? (How)
AWS_ENDPOINT_URL_DEADLINEwhenever we install a service model.json.gz) service model filesServiceModelclass was responsible for too many things. Removed the file paths and the AWS CLI commands from the class to simplify the code.KEEP_WORKER_AFTER_FAILUREactually keep the worker around after failingWORKER_REGIONand useREGIONinsteadWhat is the impact of this change?
KEEP_WORKER_AFTER_FAILUREworksWORKER_REGIONconfiguration is deprecatedHow was this change tested?
hatch build && hatch run testWas this change documented?
No
Is this a breaking change?
Yes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.