Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report action timeout as failed with timeout message #165

Merged
merged 1 commit into from
Feb 21, 2024

Commits on Feb 21, 2024

  1. feat: report action timeout as failed with timeout message

    Problem:
    
    Previously, if an OpenJD Action was canceled due to a timeout being
    reached then we'd report the action as just canceled. The change to
    update to openjd-sessions 0.5.0
    ( #160 )
    made it so that timeout actions would report as FAILED, but didn't
    change the failure message to make it clear that the reason for the
    failure was a timeout.
    
    Solution:
    
    We mutate the action status when we recieve it to override the failure
    message with one that indicates that the action has reached its runtime
    limit.
    
    Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
    ddneilson committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    4cc3f90 View commit details
    Browse the repository at this point in the history