chore(deps): update to openjd-sessions 0.5.x #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddneilson
force-pushed
the
ddneilson/update_openjd_sessions_dep_0.5
branch
2 times, most recently
from
528092f
to
10e8895
Compare
Summary: The first public release of the openjd-sessions package has been made as version 0.5.0. This updates the agent to this version and makes the required breaking changes. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
ddneilson
force-pushed
the
ddneilson/update_openjd_sessions_dep_0.5
branch
from
10e8895
to
29eb33f
Compare
gmchale79
approved these changes
Feb 17, 2024
npmacl
approved these changes
Feb 17, 2024
ddneilson
added a commit
that referenced
this pull request
Feb 21, 2024
Problem: Previously, if an OpenJD Action was canceled due to a timeout being reached then we'd report the action as just canceled. The change to update to openjd-sessions 0.5.0 ( #160 ) made it so that timeout actions would report as FAILED, but didn't change the failure message to make it clear that the reason for the failure was a timeout. Solution: We mutate the action status when we recieve it to override the failure message with one that indicates that the action has reached its runtime limit. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
ddneilson
added a commit
that referenced
this pull request
Feb 21, 2024
Problem: Previously, if an OpenJD Action was canceled due to a timeout being reached then we'd report the action as just canceled. The change to update to openjd-sessions 0.5.0 ( #160 ) made it so that timeout actions would report as FAILED, but didn't change the failure message to make it clear that the reason for the failure was a timeout. Solution: We mutate the action status when we recieve it to override the failure message with one that indicates that the action has reached its runtime limit. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
ddneilson
added a commit
that referenced
this pull request
Feb 21, 2024
Problem: Previously, if an OpenJD Action was canceled due to a timeout being reached then we'd report the action as just canceled. The change to update to openjd-sessions 0.5.0 ( #160 ) made it so that timeout actions would report as FAILED, but didn't change the failure message to make it clear that the reason for the failure was a timeout. Solution: We mutate the action status when we recieve it to override the failure message with one that indicates that the action has reached its runtime limit. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
ddneilson
added a commit
that referenced
this pull request
Feb 21, 2024
Problem: Previously, if an OpenJD Action was canceled due to a timeout being reached then we'd report the action as just canceled. The change to update to openjd-sessions 0.5.0 ( #160 ) made it so that timeout actions would report as FAILED, but didn't change the failure message to make it clear that the reason for the failure was a timeout. Solution: We mutate the action status when we recieve it to override the failure message with one that indicates that the action has reached its runtime limit. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
ddneilson
added a commit
that referenced
this pull request
Feb 21, 2024
Problem: Previously, if an OpenJD Action was canceled due to a timeout being reached then we'd report the action as just canceled. The change to update to openjd-sessions 0.5.0 ( #160 ) made it so that timeout actions would report as FAILED, but didn't change the failure message to make it clear that the reason for the failure was a timeout. Solution: We mutate the action status when we recieve it to override the failure message with one that indicates that the action has reached its runtime limit. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com>
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
Summary: The first public release of the openjd-sessions package has been made as version 0.5.0. This updates the agent to this version and makes the required breaking changes. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
Problem: Previously, if an OpenJD Action was canceled due to a timeout being reached then we'd report the action as just canceled. The change to update to openjd-sessions 0.5.0 ( #160 ) made it so that timeout actions would report as FAILED, but didn't change the failure message to make it clear that the reason for the failure was a timeout. Solution: We mutate the action status when we recieve it to override the failure message with one that indicates that the action has reached its runtime limit. Signed-off-by: Daniel Neilson <53624638+ddneilson@users.noreply.github.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
What was the problem/requirement? (What/Why)
The worker agent hasn't had an update of its openjd-sessions dependency in quite some time. It's time to do that.
What was the solution? (How)
This updates the agent to
openjd-sessions0.5.x and makes the required breaking changes.What is the impact of this change?
We take on improvements that have been made to the runtime. e.g. improved session logs, and reporting of action timeouts separately from cancelations.
How was this change tested?
I've updated the unit tests and run the agent locally to run a 'sleep' job.
Was this change documented?
N/A
Is this a breaking change?
No