Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 3.7 #4349

Merged
merged 4 commits into from
Nov 5, 2019
Merged

Conversation

manueliglesias
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@Amplifiyer Amplifiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manueliglesias for quick fix!

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #4349 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4349   +/-   ##
=======================================
  Coverage   78.72%   78.72%           
=======================================
  Files         165      165           
  Lines        9032     9032           
  Branches     1872     1872           
=======================================
  Hits         7110     7110           
  Misses       1783     1783           
  Partials      139      139
Impacted Files Coverage Δ
.../Providers/AmazonAIInterpretPredictionsProvider.ts 78.57% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61d906...f157574. Read the comment docs.

@manueliglesias manueliglesias merged commit 218c8d5 into aws-amplify:master Nov 5, 2019
Amplifiyer pushed a commit to Amplifiyer/amplify-js that referenced this pull request Nov 25, 2019
* Use workspace typescript

* Remove typescript from packages devDependencies

* Upgrade to typescript 3.7.2

* Disambiguate types
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants