Skip to content

Commit 218c8d5

Browse files
chore: Typescript 3.7 (#4349)
* Use workspace typescript * Remove typescript from packages devDependencies * Upgrade to typescript 3.7.2 * Disambiguate types
1 parent e61d906 commit 218c8d5

File tree

5 files changed

+8
-11
lines changed

5 files changed

+8
-11
lines changed

.vscode/settings.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"editor.formatOnSave": true,
3-
"editor.insertSpaces": false
3+
"editor.insertSpaces": false,
4+
"typescript.tsdk": "node_modules/typescript/lib"
45
}

package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@
4040
},
4141
"homepage": "https://aws-amplify.github.io/",
4242
"devDependencies": {
43-
"@types/jest": "^24.0.18",
44-
"@types/node": "^8.9.5",
4543
"@babel/cli": "^7.0.0",
4644
"@babel/core": "^7.0.0",
4745
"@babel/preset-env": "^7.0.0",
4846
"@babel/preset-react": "^7.0.0",
47+
"@types/jest": "^24.0.18",
48+
"@types/node": "^8.9.5",
4949
"babel-loader": "^8.0.0",
5050
"codecov": "^1.0.1",
5151
"compression-webpack-plugin": "^1.1.3",
@@ -67,7 +67,7 @@
6767
"tslint": "^5.7.0",
6868
"tslint-config-airbnb": "^5.8.0",
6969
"typedoc": "^0.11.0",
70-
"typescript": "^3.5.3",
70+
"typescript": "^3.7.2",
7171
"uglifyjs-webpack-plugin": "^0.4.6",
7272
"webpack": "^4.32.0",
7373
"webpack-bundle-analyzer": "^3.3.2",

packages/core/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@
3737
"devDependencies": {
3838
"find": "^0.2.7",
3939
"prepend-file": "^1.3.1",
40-
"prettier": "^1.7.4",
41-
"typescript": "^3.2.2"
40+
"prettier": "^1.7.4"
4241
},
4342
"dependencies": {
4443
"aws-sdk": "2.518.0",

packages/predictions/src/Providers/AmazonAIInterpretPredictionsProvider.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,8 @@ export default class AmazonAIInterpretPredictionsProvider extends AbstractInterp
127127
keyPhrases: results[4] || [],
128128
language: results[0] || '',
129129
sentiment: results[2],
130-
syntax: results[3] || [],
131-
textEntities: results[1] || [],
130+
syntax: <TextSyntax[]>results[3] || [],
131+
textEntities: <TextEntities[]>results[1] || [],
132132
},
133133
});
134134
} catch (err) {

packages/storage/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@
3131
"url": "https://github.com/aws/aws-amplify/issues"
3232
},
3333
"homepage": "https://aws-amplify.github.io/",
34-
"devDependencies": {
35-
"typescript": "^3.2.2"
36-
},
3734
"dependencies": {
3835
"@aws-amplify/core": "^1.2.4"
3936
},

0 commit comments

Comments
 (0)