Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms hotfixes #744

Merged
merged 6 commits into from
Nov 3, 2022
Merged

Forms hotfixes #744

merged 6 commits into from
Nov 3, 2022

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Nov 3, 2022

Issue #, if available:

Description of changes:
Forms hotfixes:

  1. chore: alias model name collision for forms #740
  2. fix: forms checkbox to reflect correct model state #738
  3. fix: less than char validation #739
  4. fix: allow empty string for url field #735
  5. fix: alias model names collision with component types #733

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Jshhhh and others added 6 commits November 3, 2022 12:49
* chore: set timezone to UTC before starting cypress tests (#730)

* chore: set timezone to UTC before starting cypress tests

* fix: cli test fix

Co-authored-by: Brandon Lyons <lyonsbp@amazon.com>
Co-authored-by: Scott Young <scoyou@amazon.com>

* fix: allow empty string for url field

Co-authored-by: Brandon Lyons <lyonsbp@amazon.com>
Co-authored-by: Scott Young <scoyou@amazon.com>
Co-authored-by: Justin Shih <jushih@amazon.com>
Co-authored-by: Justin Shih <jushih@amazon.com>
* chore: set timezone to UTC before starting cypress tests (#730)

* chore: set timezone to UTC before starting cypress tests

* fix: cli test fix

Co-authored-by: Brandon Lyons <lyonsbp@amazon.com>
Co-authored-by: Scott Young <scoyou@amazon.com>

* fix: alias model names collision with component types

Co-authored-by: Brandon Lyons <lyonsbp@amazon.com>
Co-authored-by: Scott Young <scoyou@amazon.com>
Co-authored-by: Justin Shih <jushih@amazon.com>
Co-authored-by: Justin Shih <jushih@amazon.com>
Co-authored-by: Scott Young <scoyou@amazon.com>
* fix: refresh stale data on update form

* fix: fix forms test from main

Co-authored-by: Scott Young <scoyou@amazon.com>
Co-authored-by: Justin Shih <jushih@amazon.com>
@Jshhhh Jshhhh requested a review from a team as a code owner November 3, 2022 19:59
@codecov-commenter
Copy link

Codecov Report

Merging #744 (dfe95af) into main (7ab3126) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
+ Coverage   91.31%   91.41%   +0.10%     
==========================================
  Files         102      102              
  Lines        3996     4044      +48     
  Branches     1115     1129      +14     
==========================================
+ Hits         3649     3697      +48     
  Misses        325      325              
  Partials       22       22              
Impacted Files Coverage Δ
...ges/codegen-ui-react/lib/forms/component-helper.ts 96.96% <ø> (ø)
packages/codegen-ui-react/lib/forms/form-state.ts 98.30% <ø> (ø)
packages/codegen-ui-react/lib/workflow/mutation.ts 96.93% <ø> (ø)
...lib/generate-form-definition/helpers/form-field.ts 100.00% <ø> (ø)
.../codegen-ui-react/lib/amplify-ui-renderers/form.ts 97.82% <100.00%> (+0.04%) ⬆️
...codegen-ui-react/lib/forms/form-renderer-helper.ts 98.22% <100.00%> (+0.02%) ⬆️
.../codegen-ui-react/lib/forms/react-form-renderer.ts 81.09% <100.00%> (+0.11%) ⬆️
packages/codegen-ui-react/lib/forms/type-helper.ts 100.00% <100.00%> (ø)
packages/codegen-ui-react/lib/helpers/index.ts 100.00% <100.00%> (ø)
.../codegen-ui-react/lib/imports/import-collection.ts 97.05% <100.00%> (+2.94%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab3126...dfe95af. Read the comment docs.

@hein-j hein-j merged commit 45a2e81 into main Nov 3, 2022
@hein-j hein-j deleted the forms-hotfix branch November 3, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants