-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms hotfixes #744
Merged
Merged
Forms hotfixes #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: set timezone to UTC before starting cypress tests (#730) * chore: set timezone to UTC before starting cypress tests * fix: cli test fix Co-authored-by: Brandon Lyons <lyonsbp@amazon.com> Co-authored-by: Scott Young <scoyou@amazon.com> * fix: allow empty string for url field Co-authored-by: Brandon Lyons <lyonsbp@amazon.com> Co-authored-by: Scott Young <scoyou@amazon.com> Co-authored-by: Justin Shih <jushih@amazon.com>
Co-authored-by: Justin Shih <jushih@amazon.com>
* chore: set timezone to UTC before starting cypress tests (#730) * chore: set timezone to UTC before starting cypress tests * fix: cli test fix Co-authored-by: Brandon Lyons <lyonsbp@amazon.com> Co-authored-by: Scott Young <scoyou@amazon.com> * fix: alias model names collision with component types Co-authored-by: Brandon Lyons <lyonsbp@amazon.com> Co-authored-by: Scott Young <scoyou@amazon.com> Co-authored-by: Justin Shih <jushih@amazon.com>
Co-authored-by: Justin Shih <jushih@amazon.com>
Co-authored-by: Scott Young <scoyou@amazon.com>
* fix: refresh stale data on update form * fix: fix forms test from main Co-authored-by: Scott Young <scoyou@amazon.com> Co-authored-by: Justin Shih <jushih@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #744 +/- ##
==========================================
+ Coverage 91.31% 91.41% +0.10%
==========================================
Files 102 102
Lines 3996 4044 +48
Branches 1115 1129 +14
==========================================
+ Hits 3649 3697 +48
Misses 325 325
Partials 22 22
Continue to review full report at Codecov.
|
cwoolum
approved these changes
Nov 3, 2022
hein-j
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Forms hotfixes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.