Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from main #742

Merged
merged 2 commits into from
Nov 3, 2022
Merged

merge from main #742

merged 2 commits into from
Nov 3, 2022

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Nov 3, 2022

Issue #, if available:

Description of changes:

  • rebase with main
  • fix model name query for change in main

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh requested a review from a team as a code owner November 3, 2022 17:56
@codecov-commenter
Copy link

Codecov Report

Merging #742 (6f706a5) into tagged-release/forms-hotfix (bbfa57d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                       Coverage Diff                       @@
##           tagged-release/forms-hotfix     #742      +/-   ##
===============================================================
- Coverage                        91.42%   91.41%   -0.01%     
===============================================================
  Files                              102      102              
  Lines                             4046     4044       -2     
  Branches                          1130     1129       -1     
===============================================================
- Hits                              3699     3697       -2     
  Misses                             325      325              
  Partials                            22       22              
Impacted Files Coverage Δ
.../codegen-ui-react/lib/amplify-ui-renderers/form.ts 97.82% <ø> (ø)
...ges/codegen-ui-react/lib/forms/component-helper.ts 96.96% <ø> (ø)
packages/codegen-ui-react/lib/forms/form-state.ts 98.30% <ø> (ø)
packages/codegen-ui-react/lib/workflow/mutation.ts 96.93% <ø> (ø)
...lib/generate-form-definition/helpers/form-field.ts 100.00% <ø> (ø)
...codegen-ui-react/lib/forms/form-renderer-helper.ts 98.22% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221e8d5...6f706a5. Read the comment docs.

@Jshhhh Jshhhh merged commit 8e6f1ad into tagged-release/forms-hotfix Nov 3, 2022
@Jshhhh Jshhhh deleted the forms-hotfix-merge branch November 3, 2022 19:36
Jshhhh added a commit that referenced this pull request Nov 3, 2022
* fix: refresh stale data on update form

* fix: fix forms test from main

Co-authored-by: Scott Young <scoyou@amazon.com>
Co-authored-by: Justin Shih <jushih@amazon.com>
hein-j pushed a commit that referenced this pull request Nov 3, 2022
* fix: refresh stale data on update form

* fix: fix forms test from main

Co-authored-by: Scott Young <scoyou@amazon.com>
Co-authored-by: Justin Shih <jushih@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants