feat: add default initial value for form component state #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
force-pushed
the
default-initial-state
branch
from
d56a28e
to
ecbd5b5
Compare
alharris-at
approved these changes
Feb 10, 2022
Comment on lines
133
to
134
| export const PrimitiveDefaultPropertyValue: Partial< | ||
| Record<Primitive, { [property: string]: FixedStudioComponentProperty }> |
There was a problem hiding this comment.
Not sure if it's more succinct or readable, but I think this can be defined as a PrimitiveLevelPropConfig<FixedStudioComponentProperty>
There was a problem hiding this comment.
Oh nice! I didn't notice we had that.
Codecov Report
@@ Coverage Diff @@
## tagged-release/q1-release #396 +/- ##
=============================================================
- Coverage 93.27% 93.27% -0.01%
=============================================================
Files 43 43
Lines 1681 1695 +14
Branches 370 375 +5
=============================================================
+ Hits 1568 1581 +13
- Misses 110 111 +1
Partials 3 3
Continue to review full report at Codecov.
|
This was referenced Feb 17, 2022
Closed
Merged
alharris-at
pushed a commit
that referenced
this pull request
Feb 24, 2022
alharris-at
pushed a commit
that referenced
this pull request
Feb 25, 2022
alharris-at
pushed a commit
that referenced
this pull request
Feb 25, 2022
alharris-at
pushed a commit
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Set default initial state value for form components.
List was determined by interacting with TwoWayBinding tests on integration app and adding default initial values for components that gave a warning.
Todo in another change:
If a
defaultValueis set by the customer and the component becomes controlled the defaultValue needs to be removed because the form components cannot have bothdefaultValueandvalue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.