Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/allow variant object keys #427

Merged

Conversation

alharris-at
Copy link
Contributor

@alharris-at alharris-at commented Feb 18, 2022

Issue #, if available:
N/A

Description of changes:

  • Add a new flag to jsonToLiteral, so we can attempt to marshall variant objects, allowing passing icon viewData/paths objects.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alharris-at alharris-at requested a review from a team February 18, 2022 22:49
@alharris-at alharris-at changed the base branch from main to tagged-release/q1-release February 18, 2022 22:50
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #427 (b07b704) into tagged-release/q1-release (f0f373a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           tagged-release/q1-release     #427      +/-   ##
=============================================================
+ Coverage                      93.07%   93.09%   +0.02%     
=============================================================
  Files                             45       45              
  Lines                           1733     1739       +6     
  Branches                         373      375       +2     
=============================================================
+ Hits                            1613     1619       +6     
  Misses                           116      116              
  Partials                           4        4              
Impacted Files Coverage Δ
...gen-ui-react/lib/react-studio-template-renderer.ts 91.42% <ø> (ø)
...react/lib/react-studio-template-renderer-helper.ts 91.78% <100.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f373a...b07b704. Read the comment docs.

@alharris-at alharris-at force-pushed the feature/allow-variant-object-keys branch from ace3058 to b07b704 Compare February 18, 2022 22:59
@alharris-at alharris-at merged commit 42204cd into tagged-release/q1-release Feb 18, 2022
@alharris-at alharris-at deleted the feature/allow-variant-object-keys branch February 18, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants