feat: use unique identifier for actions #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
commented
Jan 26, 2022
| @@ -67,7 +57,7 @@ export class ReactComponentRenderer<TPropIn> extends ComponentRendererBase< | |||
| buildOpeningElementProperties(value, key), | |||
| ); | |||
| const eventAttributes = Object.entries(this.component.events || {}).map(([key, value]) => | |||
| buildOpeningElementEvents(value, mapGenericEventToReact(key as StudioGenericEvent)), | |||
There was a problem hiding this comment.
Pushed mapGenericEventToReact further down so that we would get the same result form getActionIdentifier.
|
I think to reduce the wordiness of this, we may be able to just generate the action name from the component name and action, since that combination should be unique. The action type probably doesn't need be put in the variable, since it's referenced immediately after in the declaration. That's also easy enough to change later, so this overall LGTM. |
alharris-at
approved these changes
Jan 26, 2022
|
Good idea, I will update to this approach. |
dpilch
force-pushed
the
workflow/unique-identifier
branch
from
c67c534
to
4461037
Compare
alharris-at
approved these changes
Jan 27, 2022
This was referenced Feb 17, 2022
Closed
Merged
alharris-at
pushed a commit
that referenced
this pull request
Feb 24, 2022
alharris-at
pushed a commit
that referenced
this pull request
Feb 25, 2022
alharris-at
pushed a commit
that referenced
this pull request
Feb 25, 2022
alharris-at
pushed a commit
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have any suggestions on how the unique identifier should be constructed please leave a comment. I just went with one structure I though was sensible.
I needed to move some functions to a new file to avoid a cyclical dependency between
action.tsandreact-component-render-helper.ts.