Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_test docstring to clarify state parameter #6053

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

mikigo
Copy link
Contributor

@mikigo mikigo commented Oct 29, 2024

In

:param test: A dict with test internal state

The parameter description of 'test' does not match the parameter 'state'

and

Refactor: Remove unused 'option = None' initialization

Signed-off-by: mikigo huangmingqiang@uniontech.com

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.48%. Comparing base (f8537a5) to head (46d0b63).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6053      +/-   ##
==========================================
+ Coverage   54.42%   54.48%   +0.06%     
==========================================
  Files         202      202              
  Lines       21885    21884       -1     
==========================================
+ Hits        11911    11924      +13     
+ Misses       9974     9960      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mikigo, thank you for your updates. I think there was a small misunderstanding on #6052, sorry about that. What I meant was that you need to add Signed-off-by: mikigo <huangmingqiang@uniontech.com> to your commits messages no to PRs message, can you please fix that. Also, on #6052 your changes were split into two commits, which is a right choice. Please do that again.

Small tip, you don't need to close this PR and open a new one. You can apply your changes with git push --force to this PR.

@mikigo mikigo force-pushed the master branch 2 times, most recently from 83b9e62 to 9ddbbb3 Compare November 1, 2024 06:25
Signed-off-by: mikigo <huangmingqiang@uniontech.com>
Signed-off-by: mikigo <huangmingqiang@uniontech.com>
@mikigo
Copy link
Contributor Author

mikigo commented Nov 1, 2024

Thank you for your feedback! I have made the necessary changes as requested.

  • Modified Commit Messages: I have updated the commit messages to include the required information.

  • Split Commits: I have split the previous single commit into two separate commits.

  • Force Pushed: I have force pushed the changes to this PR.

Please review the changes and let me know if there is anything else I need to address.

Thanks again for your guidance!

Best regards,
mikigo

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mikigo, thank you for the updates it LGTM, the CI failures are not related to this PR.

@richtja richtja merged commit bb45e43 into avocado-framework:master Nov 1, 2024
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 109
Development

Successfully merging this pull request may close these issues.

2 participants