-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update check_test docstring to clarify state parameter #6053
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6053 +/- ##
==========================================
+ Coverage 54.42% 54.48% +0.06%
==========================================
Files 202 202
Lines 21885 21884 -1
==========================================
+ Hits 11911 11924 +13
+ Misses 9974 9960 -14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mikigo, thank you for your updates. I think there was a small misunderstanding on #6052, sorry about that. What I meant was that you need to add Signed-off-by: mikigo <huangmingqiang@uniontech.com>
to your commits messages no to PRs message, can you please fix that. Also, on #6052 your changes were split into two commits, which is a right choice. Please do that again.
Small tip, you don't need to close this PR and open a new one. You can apply your changes with git push --force
to this PR.
83b9e62
to
9ddbbb3
Compare
Signed-off-by: mikigo <huangmingqiang@uniontech.com>
Signed-off-by: mikigo <huangmingqiang@uniontech.com>
Thank you for your feedback! I have made the necessary changes as requested.
Please review the changes and let me know if there is anything else I need to address. Thanks again for your guidance! Best regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mikigo, thank you for the updates it LGTM, the CI failures are not related to this PR.
In
avocado/avocado/core/result.py
Line 103 in 3b1f5cb
The parameter description of 'test' does not match the parameter 'state'
and
Refactor: Remove unused 'option = None' initialization
Signed-off-by: mikigo huangmingqiang@uniontech.com