Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_test docstring to clarify state parameter #6052

Closed
wants to merge 2 commits into from

Conversation

mikigo
Copy link
Contributor

@mikigo mikigo commented Oct 26, 2024

In

:param test: A dict with test internal state

The parameter description of 'test' does not match the parameter 'state'

and

Refactor: Remove unused 'option = None' initialization

Signed-off-by: mikigo huangmingqiang@uniontech.com

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.48%. Comparing base (d5569ca) to head (1a02d4b).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6052      +/-   ##
==========================================
+ Coverage   54.47%   54.48%   +0.01%     
==========================================
  Files         202      202              
  Lines       21874    21884      +10     
==========================================
+ Hits        11915    11923       +8     
- Misses       9959     9961       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mikigo, thank you for contributing to Avocado. Your changes LGTM, but you need to make updates to your commit messages to be aligned with our committing rules.

Please add Signed-off-by: mikigo <huangmingqiang@uniontech.com> to each of your commits. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 109
Development

Successfully merging this pull request may close these issues.

2 participants