Fix color contrast and minor bugs #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Looks great! I had originally missed the date_ssi->date_issued_ssi change in my summary comment so I added it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5346
Fixes #5339
This PR also includes a bug fix so that child media objects will display on the Collection show page. We missed a solr check in the media object helper that broke when we updated the solr field, resulting in an infinite loading circle.
This PR also includes a minor change for the add to playlist button javascript to fix a console message I encountered.