Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust indexing so all MO metadata values get added to proxy #5425

Merged
merged 8 commits into from
Nov 15, 2023
Merged

Adjust indexing so all MO metadata values get added to proxy #5425

merged 8 commits into from
Nov 15, 2023

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Oct 17, 2023 •
edited
Loading

Do not merge and reindex until after user testing. Earliest merge date is 11/15/23.

@masaball masaball force-pushed the speedyaf_missing_data branch from fb62b15 to 22b14c6 Compare November 6, 2023 15:36
cjcolvar
cjcolvar reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really close!

Reviewing this reminds me the importance of #5411 since there are some fields I noticed that I think maybe should be changed to stored but aren't in the scope of this PR since they aren't in the IIIF manifest.

@masaball
Adjust indexing so all MO metadata values get added to proxy
a0826d9
@masaball
Add defaults to the proxy for new solr fields
b2f395a
@masaball
Do not include sourceless other_identifiers in proxy
08fc7ae 
The solr_doc includes the master file ids in the other identifier field.
These ids are not included in the accessor on the media object. These
ids also are of a different format than the media object's normal
other_identifiers. We need to exclude the master file ids from the
accessor on the proxy because of those factors.
@masaball
Return [] instead of nil for proxy methods
860245f
@masaball
Rework handling of hash fields and fix catalog
4bbb709
@masaball
Clean up indexing terms
4d85784
@masaball masaball force-pushed the speedyaf_missing_data branch from 22b14c6 to 4d85784 Compare November 9, 2023 22:12
cjcolvar
cjcolvar reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One small fix and it should be good to go! 🎉

@masaball @cjcolvar
Use other_identifier_sim in all_text_values
6e632b1 
`other_identifier_ssm` is an array of JSON hashes, while `other_identifier_sim` is just the identifier values. We should use these values in the `all_text_value` field to match the original implementation and avoid pitfalls related to feeding JSON into the searchable field.

Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
cjcolvar
cjcolvar previously approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cjcolvar cjcolvar merged commit 55974ff into develop Nov 15, 2023
@cjcolvar cjcolvar deleted the speedyaf_missing_data branch November 15, 2023 16:39
@cjcolvar
Copy link
Member

cjcolvar commented Nov 17, 2023 •
edited
Loading

For future reference these are the changes to the solr document in this PR:

Changed fields:
summary_ssi -> abstract_ssi
publisher_sim -> publisher_ssim
contributor_sim -> contributor_ssim
subject_sim -> subject_ssim
genre_sim -> genre_ssim
table_of_contents_sim -> table_of_contents_ssim
access_sim -> usage_ssim
format_sim -> resource_type_ssim
location_sim -> location_ssim
material_sim -> material_ssim
subject_topic_sim -> topical_subject_ssim
subject_geographic_sim -> geographic_subject_ssim
subject_temporal_sim -> temporal_subject_ssim
subject_occupation_sim -> occupation_subject_ssim
subject_person_sim -> person_subject_ssim
subject_corporate_sim -> corporate_subject_ssim
subject_family_sim -> family_subject_ssim
subject_title_sim -> title_subject_ssim
time_sim -> time_ssim
language_sim -> language_ssim
language_code_sim -> language_code_ssim
physical_description_sim -> physical_description_ssim
terms_of_use_si -> terms_of_use_ssi
date_sim -> date_ssim
date_digitized_sim -> date_digitized_ssim
all_comments_sim -> all_comments_ssim
date_ingested_sim -> date_ingested_ssim
date_ssi -> date_issued_ssi

Added hash fields:
note_ssm
other_identifier_ssm
related_item_url_ssm

@cjcolvar cjcolvar mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masaball @cjcolvar