apply concatenate node update #62
Conversation
|
@YoshiRi
|
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
|
@miursh |
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
|
fixed in b710878. |
| "/sensing/lidar/top/outlier_filtered/pointcloud_synchronized", | ||
| "/sensing/lidar/left/outlier_filtered/pointcloud_synchronized", | ||
| "/sensing/lidar/right/outlier_filtered/pointcloud_synchronized", |
There was a problem hiding this comment.
/sensing/lidar/top/synchronized/pointcloud sounds better to me, like other nodes output
There was a problem hiding this comment.
If you want that, I need to update concatenate node file because its output topic names is created by adding "_synchronized" to the original message.
There was a problem hiding this comment.
Ahh... I do want, but not urgent.
Defining like ~/synchronized/pointcloud in codes, and passing (or remapping) actual topic name from launcher is almost autoware coding manner.
|
This pull request has been automatically marked as stale because it has not had recent activity. |
|
This PR is renewed |
Pull request was closed
Description
Apply https://github.com/autowarefoundation/autoware.universe/pull/3312/files changes to sample_sensor_kit_launcher
Related links
autowarefoundation/autoware.universe#3312
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.