-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_planning_msgs): migrate autoware_auto_planning_msg to autoware_planning_msg #66
Merged
mitsudome-r
merged 12 commits into
autowarefoundation:main
from
shulanbushangshu:add-autoware-planning-msg
Aug 2, 2023
Merged
feat(autoware_planning_msgs): migrate autoware_auto_planning_msg to autoware_planning_msg #66
mitsudome-r
merged 12 commits into
autowarefoundation:main
from
shulanbushangshu:add-autoware-planning-msg
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jack.song <jack.song@autocore.ai>
Signed-off-by: jack.song <jack.song@autocore.ai>
shulanbushangshu
force-pushed
the
add-autoware-planning-msg
branch
from
May 31, 2023 03:23
6d59039
to
e1692dc
Compare
Signed-off-by: jack.song <jack.song@autocore.ai>
Signed-off-by: jack.song <jack.song@autocore.ai>
shulanbushangshu
force-pushed
the
add-autoware-planning-msg
branch
from
May 31, 2023 03:34
38f60c7
to
0c5e6cb
Compare
Signed-off-by: jack.song <jack.song@autocore.ai>
shulanbushangshu
force-pushed
the
add-autoware-planning-msg
branch
from
May 31, 2023 03:41
9a508c1
to
d8c86e3
Compare
mitsudome-r
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I have made suggestions to remove unused messages.
Signed-off-by: jack.song <jack.song@autocore.ai>
shulanbushangshu
force-pushed
the
add-autoware-planning-msg
branch
from
July 11, 2023 01:52
ae3c53a
to
e19c0cb
Compare
Signed-off-by: jack.song <jack.song@autocore.ai>
shulanbushangshu
force-pushed
the
add-autoware-planning-msg
branch
from
July 11, 2023 01:59
acbe693
to
9a65975
Compare
Signed-off-by: jack.song <jack.song@autocore.ai>
shulanbushangshu
force-pushed
the
add-autoware-planning-msg
branch
from
July 11, 2023 02:15
ad482a7
to
6574530
Compare
Signed-off-by: jack.song <jack.song@autocore.ai>
shulanbushangshu
force-pushed
the
add-autoware-planning-msg
branch
from
July 11, 2023 02:20
c2a727b
to
ca89c65
Compare
mitsudome-r
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: jack.song <jack.song@autocore.ai>
shulanbushangshu
force-pushed
the
add-autoware-planning-msg
branch
from
July 21, 2023 02:04
ee020f5
to
9a97c46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
migrate autoware_auto_mapping_msgs to autoware_planning_msgs.
migrate messages:
Path.msg
PathPoint.msg
PathPointWithLaneId.msg
PathWithLaneId.msg
Trajectory.msg
TrajectoryPoint.msg
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.