Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_planning_msgs): migrate autoware_auto_planning_msg to autoware_planning_msg #66

Merged

Conversation

shulanbushangshu
Copy link
Contributor

@shulanbushangshu shulanbushangshu commented May 31, 2023

Description

migrate autoware_auto_mapping_msgs to autoware_planning_msgs.

migrate messages:
Path.msg
PathPoint.msg
PathPointWithLaneId.msg
PathWithLaneId.msg
Trajectory.msg
TrajectoryPoint.msg

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: jack.song <jack.song@autocore.ai>
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu shulanbushangshu force-pushed the add-autoware-planning-msg branch from 6d59039 to e1692dc Compare May 31, 2023 03:23
Signed-off-by: jack.song <jack.song@autocore.ai>
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu shulanbushangshu force-pushed the add-autoware-planning-msg branch from 38f60c7 to 0c5e6cb Compare May 31, 2023 03:34
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu shulanbushangshu force-pushed the add-autoware-planning-msg branch from 9a508c1 to d8c86e3 Compare May 31, 2023 03:41
@shulanbushangshu shulanbushangshu requested a review from xmfcx June 19, 2023 08:17
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have made suggestions to remove unused messages.

autoware_planning_msgs/CMakeLists.txt Outdated Show resolved Hide resolved
autoware_planning_msgs/CMakeLists.txt Outdated Show resolved Hide resolved
autoware_planning_msgs/CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: jack.song <jack.song@autocore.ai>
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu shulanbushangshu force-pushed the add-autoware-planning-msg branch from acbe693 to 9a65975 Compare July 11, 2023 01:59
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu shulanbushangshu force-pushed the add-autoware-planning-msg branch from ad482a7 to 6574530 Compare July 11, 2023 02:15
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu shulanbushangshu force-pushed the add-autoware-planning-msg branch from c2a727b to ca89c65 Compare July 11, 2023 02:20
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu shulanbushangshu force-pushed the add-autoware-planning-msg branch from ee020f5 to 9a97c46 Compare July 21, 2023 02:04
@mitsudome-r mitsudome-r merged commit 62f341d into autowarefoundation:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants