Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(centerpoint, pointpainting): rearrange ML model and package params #915

Merged

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Mar 11, 2024

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen requested a review from Shin-kyoto March 12, 2024 01:00
badai-nguyen and others added 2 commits March 14, 2024 01:04
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen changed the title refactor:(centerpoint, pointpainting): ML model params rework refactor(centerpoint, pointpainting): ML model params rework Mar 13, 2024
@badai-nguyen badai-nguyen changed the title refactor(centerpoint, pointpainting): ML model params rework refactor(centerpoint, pointpainting): rearrange ML model and package params Mar 13, 2024
@badai-nguyen badai-nguyen marked this pull request as ready for review March 14, 2024 00:15
@badai-nguyen badai-nguyen marked this pull request as draft March 14, 2024 05:30
badai-nguyen and others added 3 commits March 14, 2024 19:46
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen marked this pull request as ready for review March 18, 2024 00:09
@badai-nguyen
Copy link
Contributor Author

@knzo25 @Shin-kyoto
I fixed your change request so could you review it again?

BTW, I have merged autowarefoundation/autoware#4533 tested this change on Evaluator.

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit d957c83 into autowarefoundation:main Apr 26, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants