-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(centerpoint, pointpainting): rearrange ML model and package params #915
Merged
YoshiRi
merged 14 commits into
autowarefoundation:main
from
badai-nguyen:refactor/ml_model_param_rework
Apr 26, 2024
Merged
refactor(centerpoint, pointpainting): rearrange ML model and package params #915
YoshiRi
merged 14 commits into
autowarefoundation:main
from
badai-nguyen:refactor/ml_model_param_rework
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen
changed the title
refactor:(centerpoint, pointpainting): ML model params rework
refactor(centerpoint, pointpainting): ML model params rework
Mar 13, 2024
badai-nguyen
changed the title
refactor(centerpoint, pointpainting): ML model params rework
refactor(centerpoint, pointpainting): rearrange ML model and package params
Mar 13, 2024
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@knzo25 @Shin-kyoto BTW, I have merged autowarefoundation/autoware#4533 tested this change on Evaluator.
|
YoshiRi
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to
Issue: Separate the param.yaml file for ML model parameters and ML model handle node parameters autoware.universe#6590
PR: refactor(centerpoint, pointpainting): rearrange parameters for ML models and packages autoware.universe#6591
This PR should be merged together with refactor: update ML model param files download autoware#4533
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.