Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(planning_launch): parameterize scale for lc safety check #384

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

Parameterize longitudinal_velocity_delta_time in the behavior path planner node for safe lane change.

RSS check only secure the future distance, therefore, even when RSS logic returns safe, we cannot guarantee that the physical distance between real vehicle is safe. Originally the value is fixed to 0.8 but there might be necessity to reduce or increase the value depending on situation.

Update the YAML file, the parameter struct, the node constructor, and the safety check function to use the new parameter.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 requested a review from shmpwk June 6, 2023 05:20
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 40685b5 into main Jun 6, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix-lc-parameterize-vel-scale branch June 6, 2023 06:21
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
…utowarefoundation#384)

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
…owarefoundation#676) (autowarefoundation#384)

* fix(planning_launch): ignore unavoidable objects around the goal

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* Update planning_launch/config/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/avoidance/avoidance.param.yaml

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
takayuki5168 referenced this pull request in tier4/autoware_launch Jun 23, 2023
…504)

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 12, 2023
kminoda pushed a commit to kminoda/autoware_launch that referenced this pull request Sep 13, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 6, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants