This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
feat: add autoware_cmake package #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
esteve
suggested changes
May 3, 2022
esteve
approved these changes
May 3, 2022
esteve
suggested changes
May 3, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
4 tasks
esteve
approved these changes
May 4, 2022
7 tasks
1222-takeshi
pushed a commit
to 1222-takeshi/autoware_common
that referenced
this pull request
Dec 2, 2022
* feat: add autoware_cmake package Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * ignore PCL errors in clang Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As I commented in autowarefoundation/autoware.universe#762 (comment), it's useful if we can set
ROS_DISTROmacros and other compile options in common.This is a simplified version of
autoware_auto_cmake.https://gitlab.com/autowarefoundation/autoware.auto/AutowareAuto/-/tree/master/src/tools/autoware_auto_cmake
https://github.com/autowarefoundation/autoware.universe/tree/main/common/autoware_auto_cmake
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.