feat(motion_utils): add detail and pass type to VirtualWall #9940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
requested review from
rej55,
kosuke55,
satoshi-ota,
taikitanaka3,
TakaHoribe,
takayuki5168 and
tkimura4
as code owners
github-actions
bot
added
the
component:common
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kosuke55
reviewed
Jan 16, 2025
| { | ||
| visualization_msgs::msg::MarkerArray marker_array; | ||
|
|
||
| // Virtual Wall |
There was a problem hiding this comment.
Suggested change
| // Virtual Wall |
not virtual wall
| createMarkerScale(2.5 /*length*/, 0.15 /*width*/, 1.0 /*height*/), color); | ||
|
|
||
| marker.pose = vehicle_front_pose; | ||
| // marker.pose.position.z += 1.0; |
There was a problem hiding this comment.
Suggested change
| // marker.pose.position.z += 1.0; |
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added
the
run:build-and-test-differential
kosuke55
approved these changes
Jan 16, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9940 +/- ##
==========================================
+ Coverage 29.14% 29.18% +0.04%
==========================================
Files 1425 1425
Lines 107819 107851 +32
Branches 42246 42256 +10
==========================================
+ Hits 31422 31475 +53
+ Misses 73352 73324 -28
- Partials 3045 3052 +7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add
passtype: emphasize that the module intentionally goes (does not stop) on its own decision as white arrowlike the "intersection" marker in the pic
Related links
Parent Issue:
How was this PR tested?
see the description
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.