Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): using frenet planner to generate lane change path when ego near terminal #9767
base: main
Are you sure you want to change the base?
feat(lane_change): using frenet planner to generate lane change path when ego near terminal #9767
Changes from 12 commits
2672c0b
ea0e3f1
0668a28
2a6d10a
c6cd9f5
d6db912
ccceece
4c638ca
08faa0b
3253f79
7befc78
95838e1
d8ca060
5764ee7
eab7afe
36099e5
999cf89
7037ea0
ab53673
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about the use of this parameter, prepare segment is usually just a section of the current reference path, so why would it have invalid curvature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it might when the lanelet itself have high curvature.|
For example
Check warning on line 223 in planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/manager.cpp
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
Check warning on line 376 in planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/manager.cpp
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method