Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_pointcloud_preprocessor): fix autoware pointcloud preprocessor docs #9765

Merged
merged 5 commits into from
Dec 25, 2024

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Dec 24, 2024

Description

Some of the documentations are broken because of the wrong path, or default value.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@vividf vividf added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Dec 24, 2024
@vividf vividf self-assigned this Dec 24, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:require-cuda-build-and-test labels Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.66%. Comparing base (b764c57) to head (db38678).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9765      +/-   ##
==========================================
- Coverage   29.68%   29.66%   -0.02%     
==========================================
  Files        1450     1453       +3     
  Lines      108833   108701     -132     
  Branches    42740    42627     -113     
==========================================
- Hits        32305    32249      -56     
+ Misses      73357    73018     -339     
- Partials     3171     3434     +263     
Flag Coverage Δ *Carryforward flag
differential 23.85% <ø> (?)
differential-cuda 23.85% <ø> (?)
total 29.68% <ø> (+<0.01%) ⬆️ Carriedforward from 98a8778

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vividf vividf enabled auto-merge (squash) December 25, 2024 08:57
@vividf vividf merged commit 1586372 into autowarefoundation:main Dec 25, 2024
36 checks passed
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 27, 2024
…cessor docs (autowarefoundation#9765)

* fix downsample and passthrough

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

* fix: fix blockage-diag docs that page is not shown

Signed-off-by: vividf <yihsiang.fang@tier4.jp>

---------

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:require-cuda-build-and-test type:documentation Creating or refining documentation. (auto-assigned)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants