Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_avoidance_planner): fix bounds search #965

Merged
merged 2 commits into from
May 26, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented May 26, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

fix bounds search algorithm

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Comment on lines +1438 to +1439
return std::min(std::abs(a.lower_bound), std::abs(a.upper_bound)) <
std::min(std::abs(b.lower_bound), std::abs(b.upper_bound));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main change is here

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #965 (92c6ae1) into main (f5f998b) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #965      +/-   ##
========================================
- Coverage   9.94%   9.91%   -0.04%     
========================================
  Files        879     879              
  Lines      55988   56173     +185     
  Branches   10577   10577              
========================================
  Hits        5570    5570              
- Misses     45699   45884     +185     
  Partials    4719    4719              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.94% <0.00%> (ø) Carriedforward from f5f998b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lude/obstacle_avoidance_planner/common_structs.hpp 0.00% <ø> (ø)
...acle_avoidance_planner/src/debug_visualization.cpp 0.00% <ø> (ø)
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f998b...92c6ae1. Read the comment docs.

@takayuki5168 takayuki5168 marked this pull request as ready for review May 26, 2022 07:38
@kosuke55 kosuke55 self-requested a review May 26, 2022 07:44
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit 3537ec1 into autowarefoundation:main May 26, 2022
@takayuki5168 takayuki5168 deleted the feature/bounds-search-fix branch May 26, 2022 08:32
naokimatsunawa referenced this pull request in tier4/autoware.universe May 27, 2022
* feat(obstacle_avoidance_planner): fix bounds search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Jun 7, 2022
…on#965)

* feat(obstacle_avoidance_planner): fix bounds search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* feat(obstacle_avoidance_planner): fix bounds search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(obstacle_avoidance_planner): fix bounds search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(obstacle_avoidance_planner): fix bounds search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* feat(obstacle_avoidance_planner): fix bounds search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 23, 2023
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
[universe]
33dbaa4 feat(tier4_perception_launch): make switchable detection by tracker in x2 project (autowarefoundation#964)
940fb2b Merge pull request autowarefoundation#965 from tier4/beta/v0.11.0+PR5356
5aa9db1 feat(map_based_prediction): remove crossing fence path (autowarefoundation#5356)
[common]
c3a1a19 fix(visualization): display traffic reg elem id (autowarefoundation#210)
36b3825 feat(lanelet2_extention): add getAllFences (autowarefoundation#209)
44dc388 docs(lanelet2_extension): add brief description for crosswalk traffic light (autowarefoundation#208)
c360614 feat(lanelet2_extensions): add query curbstones from vector map (autowarefoundation#206)
[launcher]
a2f88f00 feat(autoware_launch): longer prediction 15.0 -> 20.0 (autowarefoundation#482)
87974c0f fix: fix stop_duration_sec param for merge_from_private (autowarefoundation#516)
f5a1dfad fix(autoware_launch): fix parameter for light weight grand segmentation (autowarefoundation#506)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants