-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_avoidance_planner): fix bounds search #965
feat(obstacle_avoidance_planner): fix bounds search #965
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
return std::min(std::abs(a.lower_bound), std::abs(a.upper_bound)) < | ||
std::min(std::abs(b.lower_bound), std::abs(b.upper_bound)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main change is here
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #965 +/- ##
========================================
- Coverage 9.94% 9.91% -0.04%
========================================
Files 879 879
Lines 55988 56173 +185
Branches 10577 10577
========================================
Hits 5570 5570
- Misses 45699 45884 +185
Partials 4719 4719
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(obstacle_avoidance_planner): fix bounds search Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix ci error Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…on#965) * feat(obstacle_avoidance_planner): fix bounds search Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix ci error Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
* feat(obstacle_avoidance_planner): fix bounds search Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix ci error Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* feat(obstacle_avoidance_planner): fix bounds search Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix ci error Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* feat(obstacle_avoidance_planner): fix bounds search Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix ci error Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* feat(obstacle_avoidance_planner): fix bounds search Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix ci error Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
feat(map_based_prediction): remove crossing fence path (autowarefoundation#5356)
[universe] 33dbaa4 feat(tier4_perception_launch): make switchable detection by tracker in x2 project (autowarefoundation#964) 940fb2b Merge pull request autowarefoundation#965 from tier4/beta/v0.11.0+PR5356 5aa9db1 feat(map_based_prediction): remove crossing fence path (autowarefoundation#5356) [common] c3a1a19 fix(visualization): display traffic reg elem id (autowarefoundation#210) 36b3825 feat(lanelet2_extention): add getAllFences (autowarefoundation#209) 44dc388 docs(lanelet2_extension): add brief description for crosswalk traffic light (autowarefoundation#208) c360614 feat(lanelet2_extensions): add query curbstones from vector map (autowarefoundation#206) [launcher] a2f88f00 feat(autoware_launch): longer prediction 15.0 -> 20.0 (autowarefoundation#482) 87974c0f fix: fix stop_duration_sec param for merge_from_private (autowarefoundation#516) f5a1dfad fix(autoware_launch): fix parameter for light weight grand segmentation (autowarefoundation#506)
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
fix bounds search algorithm
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.