Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(duplicated_node_checker): show the node name on the terminal #9609

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 10, 2024

Description

Currently, when there are duplicated nodes, we cannot see the node name unless we run rqt_runtime_monitor or something, which makes the debuggability quite low.
The duplicated_node_checker node will show the following message with the duplicated node name on the terminal.

[duplicated_node_checker_node-3] [WARN 1733839043.581189550] [system.duplicated_node_checker]: /perception/object_recognition/prediction/map_based_prediction node is duplicated. (produceDiagnostics():70)

Related links

How was this PR tested?

It worked on the planning simulator.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Dec 10, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 marked this pull request as ready for review December 10, 2024 14:00
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.57%. Comparing base (1d96a7f) to head (2dc729d).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
..._node_checker/src/duplicated_node_checker_core.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9609      +/-   ##
==========================================
- Coverage   29.57%   29.57%   -0.01%     
==========================================
  Files        1442     1442              
  Lines      108525   108526       +1     
  Branches    41411    41411              
==========================================
  Hits        32096    32096              
- Misses      73306    73307       +1     
  Partials     3123     3123              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.57% <ø> (ø) Carriedforward from 1d96a7f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shmpwk
Copy link
Contributor

shmpwk commented Dec 10, 2024

LGTM

@takayuki5168 takayuki5168 merged commit 53aaf0f into autowarefoundation:main Dec 11, 2024
47 of 48 checks passed
@takayuki5168 takayuki5168 deleted the feat/duplicated-node-checker-name-on-terminal branch December 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants