feat(autoware_lidar_centerpoint): added a check to notify if we are dropping pillars #9488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
github-actions
bot
added
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kminoda
reviewed
Nov 27, 2024
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
|
@knzo25 Would you also update the "How was this PR tested?" section in the description? |
knzo25
added
the
run:build-and-test-differential
|
@kminoda |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9488 +/- ##
==========================================
+ Coverage 29.48% 29.50% +0.02%
==========================================
Files 1439 1440 +1
Lines 108495 108480 -15
Branches 41479 41462 -17
==========================================
+ Hits 31985 32006 +21
+ Misses 73399 73366 -33
+ Partials 3111 3108 -3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kminoda
approved these changes
Nov 28, 2024
technolojin
pushed a commit
to technolojin/autoware.universe
that referenced
this pull request
Dec 5, 2024
…ropping pillars (autowarefoundation#9488) * feat: added a check to notify if we are dropping pillars Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: updated text Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * chore: throttled the message Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
technolojin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 6, 2024
…ropping pillars (autowarefoundation#9488) (#1676) * feat: added a check to notify if we are dropping pillars * chore: updated text * chore: throttled the message --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the input pointcloud generates more pillars than the model that handle, we are currently clipping them.
If that happens, we should notify users so they can consider increasing the model parameters.
Related links
Parent Issue:
How was this PR tested?
Artificially decreased the maximum amount of voxels/pillars in the config file and made sure that the error message was displayed in a throttled manner.
Notes for reviewers
If you do not re-generate the engine you will have runtime errors
Interface changes
None.
Effects on system behavior
None.